Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 549243002: Ensure that the browser’s copy of page id is in sync with the renderer’s. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pageidipc
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 15b860d93a88982267ff4970c754d4bc44c95ad4..d21b8432665d89c035e8e0a2d362a62f810313cc 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -7,9 +7,11 @@
#include "base/bind.h"
#include "base/command_line.h"
#include "base/containers/hash_tables.h"
+#include "base/debug/crash_logging.h"
#include "base/lazy_instance.h"
#include "base/metrics/histogram.h"
#include "base/metrics/user_metrics_action.h"
+#include "base/strings/string_number_conversions.h"
#include "base/time/time.h"
#include "content/browser/accessibility/accessibility_mode_helper.h"
#include "content/browser/accessibility/browser_accessibility_manager.h"
@@ -577,8 +579,19 @@ void RenderFrameHostImpl::OnDidRedirectProvisionalLoad(
int32 page_id,
const GURL& source_url,
const GURL& target_url) {
+ if (render_view_host_->page_id_ != page_id) {
+ base::debug::SetCrashKeyValue("url1",
+ source_url.possibly_invalid_spec());
+ base::debug::SetCrashKeyValue("url2",
+ target_url.possibly_invalid_spec());
+ base::debug::SetCrashKeyValue(
+ "id1", base::IntToString(render_view_host_->page_id_));
+ base::debug::SetCrashKeyValue("id2",
+ base::IntToString(page_id));
+ CHECK(false);
+ }
frame_tree_node_->navigator()->DidRedirectProvisionalLoad(
- this, page_id, source_url, target_url);
+ this, render_view_host_->page_id_, source_url, target_url);
}
// Called when the renderer navigates. For every frame loaded, we'll get this
@@ -939,6 +952,15 @@ void RenderFrameHostImpl::OnUpdateTitle(
int32 page_id,
const base::string16& title,
blink::WebTextDirection title_direction) {
+ if (render_view_host_->page_id_ != page_id) {
+ base::debug::SetCrashKeyValue(
+ "url1", GetLastCommittedURL().possibly_invalid_spec());
+ base::debug::SetCrashKeyValue(
+ "id1", base::IntToString(render_view_host_->page_id_));
+ base::debug::SetCrashKeyValue("id2",
+ base::IntToString(page_id));
+ CHECK(false);
+ }
// This message is only sent for top-level frames. TODO(avi): when frame tree
// mirroring works correctly, add a check here to enforce it.
if (title.length() > kMaxTitleChars) {
@@ -946,7 +968,7 @@ void RenderFrameHostImpl::OnUpdateTitle(
return;
}
- delegate_->UpdateTitle(this, page_id, title,
+ delegate_->UpdateTitle(this, render_view_host_->page_id_, title,
WebTextDirectionToChromeTextDirection(
title_direction));
}
« no previous file with comments | « chrome/common/crash_keys.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698