Issue 549083005: Fix an error where the onchange() only worked due to scoping rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 549083005: Fix an error where the onchange() only worked due to scoping rules. (Closed)

Created:
6 years, 3 months ago by Daniel Nishi

Modified:
6 years, 3 months ago

Reviewers:
Bernhard Bauer

CC:
Vitaly Pavlenko, chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix an error where the onchange() only worked due to scoping rules on the Website Settings page. Committed: https://crrev.com/c068f4e4cb32fa3121f41d95389c3a2a0b5d2c3c Cr-Commit-Position: refs/heads/master@{#293753}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/options/website_settings.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/549083005/1

6 years, 3 months ago (2014-09-08 15:49:28 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 5d70b6667ca8175e358435f60975c990c0d322cb

6 years, 3 months ago (2014-09-08 17:55:20 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:47:08 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c068f4e4cb32fa3121f41d95389c3a2a0b5d2c3c
Cr-Commit-Position: refs/heads/master@{#293753}