chrome/browser/resources/options/website_settings.js - Issue 549083005: Fix an error where the onchange() only worked due to scoping rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/website_settings.js

Issue 549083005: Fix an error where the onchange() only worked due to scoping rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options/website_settings.js

diff --git a/chrome/browser/resources/options/website_settings.js b/chrome/browser/resources/options/website_settings.js

index 2dd711a376858860a6009b7f752432a4af148948..140da26934dab2e1b96e8f96ad9748f41aafe5d2 100644

--- a/chrome/browser/resources/options/website_settings.js

+++ b/chrome/browser/resources/options/website_settings.js

@@ -39,7 +39,7 @@ cr.define('options', function() {

$('website-settings-overlay-confirm').onclick =

PageManager.closeOverlay.bind(PageManager);

- $('resourceType').onchange = function() {

+ $('resourceType').onchange = function(event) {

var target = event.target;

assert(target.tagName == 'SELECT');

if (target.value == 'storage')

« no previous file with comments | « no previous file | no next file » | no next file with comments »