Issue 54903004: Make HistoryURLProvider::SuggestExactInput() non-static, and take only the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54903004: Make HistoryURLProvider::SuggestExactInput() non-static, and take only the (Closed)

Created:
7 years, 1 month ago by Peter Kasting

Modified:
7 years, 1 month ago

Reviewers:
msw

CC:
chromium-reviews, James Su

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make HistoryURLProvider::SuggestExactInput() non-static, and take only the necessary input args, instead of a whole AutocompleteInput. We need a nonstatic instance of HistoryURLProvider to pass in anyway, so there's no real win from this being static. Not using an AutocompleteInput will be useful in the future when I'll be adding a call to this from OmniboxEditModel::OpenMatch(), which doesn't have an AutocompleteInput. This also sets |trim_http| to false when called from AcceptInput(); there's no need to trim the scheme here (since the user won't see the trimmed string) and doing so is actively wrong if the user typed ctrl-enter on e.g. "http://google". BUG=151044 TEST=none R=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232850

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -57 lines)			Patch
M	chrome/browser/autocomplete/history_url_provider.h	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.cc	View	6 chunks	+41 lines, -41 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_edit_model.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

7 years, 1 month ago (2013-11-05 00:25:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r232850 (presubmit successful).

Expand Messages | Collapse Messages