Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3570)

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 54903004: Make HistoryURLProvider::SuggestExactInput() non-static, and take only the (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
===================================================================
--- chrome/browser/ui/omnibox/omnibox_edit_model.cc (revision 232228)
+++ chrome/browser/ui/omnibox/omnibox_edit_model.cc (working copy)
@@ -583,7 +583,7 @@
// URL_WHAT_YOU_TYPED AutocompleteMatch. Note that using the most recent
// input instead of the currently visible text means we'll ignore any
// visible inline autocompletion: if a user types "foo" and is autocompleted
- // to "foodnetwork.com", ctrl-enter will navigate to "foo.com", not
+ // to "foodnetwork.com", ctrl-enter will navigate to "foo.com", not
// "foodnetwork.com". At the time of writing, this behavior matches
// Internet Explorer, but not Firefox.
const AutocompleteInput& old_input = autocomplete_controller()->input();
@@ -594,8 +594,9 @@
GURL(), old_input.current_page_classification(),
old_input.prevent_inline_autocomplete(), old_input.prefer_keyword(),
old_input.allow_exact_keyword_match(), old_input.matches_requested());
- AutocompleteMatch url_match = HistoryURLProvider::SuggestExactInput(
- autocomplete_controller()->history_url_provider(), input, true);
+ AutocompleteMatch url_match(
+ autocomplete_controller()->history_url_provider()->SuggestExactInput(
+ input.text(), input.canonicalized_url(), false));
if (url_match.destination_url.is_valid()) {
// We have a valid URL, we use this newly generated AutocompleteMatch.
« no previous file with comments | « chrome/browser/autocomplete/history_url_provider_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698