Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 548953002: [Password Manager] Modified to support saving passwords on forms without username fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit-tests and fixed lint errors. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index 0b69c6ca4b3dd405e16e0ac6b57a15be503d3962..2bef70ea536cbdcc88cc6057ffbfa19f8e57f1f6 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -99,10 +99,13 @@ class PasswordFormManager : public PasswordStoreConsumer {
// form.
bool IsPendingCredentialsPublicSuffixMatch();
- // Checks if the form is a valid password form. Forms which lack either
- // login or password field are not considered valid.
+ // Checks if the form is a valid password form. Forms which lack password
+ // field are not considered valid.
bool HasValidPasswordForm();
+ // Checks if the forms do not lack username field.
+ bool HasValidLogin();
+
// These functions are used to determine if this form has had it's password
// auto generated by the browser.
bool HasGeneratedPassword();
@@ -117,7 +120,7 @@ class PasswordFormManager : public PasswordStoreConsumer {
// A user opted to 'never remember' passwords for this form.
// Blacklist it so that from now on when it is seen we ignore it.
- // TODO: Make this private once we switch to the new UI.
+ // TODO(vabr): Make this private once we switch to the new UI.
vabr (Chromium) 2014/09/15 13:01:45 Why do you change this comment (and the one below)
Pritam Nikam 2014/09/15 15:02:08 Done. I've changed this to resolve Lint error. No
void PermanentlyBlacklist();
// Sets whether the password form should use additional password
@@ -138,7 +141,7 @@ class PasswordFormManager : public PasswordStoreConsumer {
// Handles save-as-new or update of the form managed by this manager.
// Note the basic data of updated_credentials must match that of
// observed_form_ (e.g DoesManage(pending_credentials_) == true).
- // TODO: Make this private once we switch to the new UI.
+ // TODO(vabr): Make this private once we switch to the new UI.
void Save();
// Call these if/when we know the form submission worked or failed.

Powered by Google App Engine
This is Rietveld 408576698