[Password Manager] Modified to support saving passwords on forms without username fields.

components/password_manager/core/browser/password_form_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 81 matching lines @@
   // Used by PasswordManager to determine whether or not to display
   // a SavePasswordBar when given the green light to save the PasswordForm
   // managed by this.
   bool IsNewLogin();
 
   // Returns true if the current pending credentials were found using
   // origin matching of the public suffix, instead of the signon realm of the
   // form.
   bool IsPendingCredentialsPublicSuffixMatch();
 
-  // Checks if the form is a valid password form. Forms which lack either
-  // login or password field are not considered valid.
+  // Checks if the form is a valid password form. Forms which lack password
+  // field are not considered valid.
   bool HasValidPasswordForm();
 
+  // Checks if the forms do not lack username field.
+  bool HasValidLogin();
+
   // These functions are used to determine if this form has had it's password
   // auto generated by the browser.
   bool HasGeneratedPassword();
   void SetHasGeneratedPassword();
 
   // Determines if we need to autofill given the results of the query.
   // Takes ownership of the elements in |result|.
   void OnRequestDone(const std::vector<autofill::PasswordForm*>& result);
 
   virtual void OnGetPasswordStoreResults(
       const std::vector<autofill::PasswordForm*>& results) OVERRIDE;
 
   // A user opted to 'never remember' passwords for this form.
   // Blacklist it so that from now on when it is seen we ignore it.
-  // TODO: Make this private once we switch to the new UI.
+  // TODO(vabr): Make this private once we switch to the new UI.

[vabr (Chromium), 2014/09/15 13:01:45]

Why do you change this comment (and the one below)? Are they related to your
change-list?

While you are right that the style requires an owner of a TODO to be specified,
changing unrelated lines in the code makes it generally harder to track down
changes (you have to go through several hops in the history), and blows up the
CL. Please do not do that.

[Pritam Nikam, 2014/09/15 15:02:08]

Done.

I've changed this to resolve Lint error. Notified pre- git cl upload script
execution.

   void PermanentlyBlacklist();
 
   // Sets whether the password form should use additional password
   // authentication if available before being used for autofill.
   void SetUseAdditionalPasswordAuthentication(
       bool use_additional_authentication);
 
   // If the user has submitted observed_form_, provisionally hold on to
   // the submitted credentials until we are told by PasswordManager whether
   // or not the login was successful. |action| describes how we deal with
   // possible usernames. If |action| is ALLOW_OTHER_POSSIBLE_USERNAMES we will
   // treat a possible usernames match as a sign that our original heuristics
   // were wrong and that the user selected the correct username from the
   // Autofill UI.
   void ProvisionallySave(const autofill::PasswordForm& credentials,
                          OtherPossibleUsernamesAction action);
 
   // Handles save-as-new or update of the form managed by this manager.
   // Note the basic data of updated_credentials must match that of
   // observed_form_ (e.g DoesManage(pending_credentials_) == true).
-  // TODO: Make this private once we switch to the new UI.
+  // TODO(vabr): Make this private once we switch to the new UI.
   void Save();
 
   // Call these if/when we know the form submission worked or failed.
   // These routines are used to update internal statistics ("ActionsTaken").
   void SubmitPassed();
   void SubmitFailed();
 
   // Returns the username associated with the credentials.
   const base::string16& associated_username() const {
     return pending_credentials_.username_value;
@@ skipping 176 matching lines @@
   ManagerAction manager_action_;
   UserAction user_action_;
   SubmitResult submit_result_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_