Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Issue 548773002: [ServiceWorker] Don't pass OPTIONS request to the ServiceWorker (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
yhirano
CC:
michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, jakearchibald
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Don't pass OPTIONS request to the ServiceWorker This is work around to avoid hijacking CORS preflight. In current implementation, CORS preflight request is also sent to the ServiceWorker. This is a bug in the implementation of HTTP fetch in DocumentThreadableLoader. But it takes time to fix this. So I want to introduce this work around because this is a security bug. BUG=409454 Committed: https://crrev.com/2c8acfe2e520a5a44e3d158441dbc2bd2057a899 Cr-Commit-Position: refs/heads/master@{#293697}

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : Add test #

Total comments: 2

Patch Set 4 : move include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -63 lines) Patch
M content/browser/service_worker/service_worker_request_handler.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
A + content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 2 3 3 chunks +86 lines, -62 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
horo
yhirano@ Could you please review this?
6 years, 3 months ago (2014-09-06 06:22:06 UTC) #3
yhirano
Can we have a test?
6 years, 3 months ago (2014-09-08 03:42:32 UTC) #4
horo
On 2014/09/08 03:42:32, yhirano wrote: > Can we have a test? Added test
6 years, 3 months ago (2014-09-08 06:21:54 UTC) #6
yhirano
lgtm https://codereview.chromium.org/548773002/diff/80001/content/browser/service_worker/service_worker_request_handler_unittest.cc File content/browser/service_worker/service_worker_request_handler_unittest.cc (right): https://codereview.chromium.org/548773002/diff/80001/content/browser/service_worker/service_worker_request_handler_unittest.cc#newcode11 content/browser/service_worker/service_worker_request_handler_unittest.cc:11: #include "content/browser/service_worker/service_worker_request_handler.h" Can you move this include to ...
6 years, 3 months ago (2014-09-08 07:58:01 UTC) #7
horo
https://codereview.chromium.org/548773002/diff/80001/content/browser/service_worker/service_worker_request_handler_unittest.cc File content/browser/service_worker/service_worker_request_handler_unittest.cc (right): https://codereview.chromium.org/548773002/diff/80001/content/browser/service_worker/service_worker_request_handler_unittest.cc#newcode11 content/browser/service_worker/service_worker_request_handler_unittest.cc:11: #include "content/browser/service_worker/service_worker_request_handler.h" On 2014/09/08 07:58:01, yhirano wrote: > Can ...
6 years, 3 months ago (2014-09-08 08:13:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/548773002/100001
6 years, 3 months ago (2014-09-08 08:14:11 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:100001) as 5463cf6821152b9f8963fad8f62d953b78b13e98
6 years, 3 months ago (2014-09-08 09:46:53 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:26 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2c8acfe2e520a5a44e3d158441dbc2bd2057a899
Cr-Commit-Position: refs/heads/master@{#293697}

Powered by Google App Engine
This is Rietveld 408576698