Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5540)

Unified Diff: chrome/browser/media/media_device_id_salt.h

Issue 54863002: Implement a salt for MediaSource IDs that can be cleared by a user. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments- unit tests still don't compile Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/media_device_id_salt.h
diff --git a/chrome/browser/media/media_device_id_salt.h b/chrome/browser/media/media_device_id_salt.h
new file mode 100644
index 0000000000000000000000000000000000000000..b603bad72578c97b67b2b51c605e2ce12dba6ff3
--- /dev/null
+++ b/chrome/browser/media/media_device_id_salt.h
@@ -0,0 +1,43 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// MediaDeviceIDSalt is responsible for creating and retrieving a salt string
+// that is used for creating MediaSource IDs that can be cached by a web
+// service. If the cache is cleared, the MediaSourceIds are invalidated.
+
+#ifndef CHROME_BROWSER_MEDIA_MEDIA_DEVICE_ID_SALT_H_
+#define CHROME_BROWSER_MEDIA_MEDIA_DEVICE_ID_SALT_H_
+
+#include <string>
+
+#include "base/prefs/pref_member.h"
+#include "base/synchronization/lock.h"
+#include "components/user_prefs/pref_registry_syncable.h"
+
+class PrefService;
+
+class MediaDeviceIDSalt {
+ public:
+ MediaDeviceIDSalt(PrefService* pref_service,
+ bool incognito);
+ ~MediaDeviceIDSalt();
+
+ std::string GetSalt();
+
+ // Registers the preferences related to Media Stream default devices.
+ static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
+ static void Reset(PrefService* pref_service);
+
+ private:
+ void OnValueReset(const std::string& pref_name);
+
+ // |lock_| is used for protecting |salt_| if cookies are cleared.
+ base::Lock lock_;
+ // |salt_| is initialized in ctor on UI thread but only read and changed on
Jói 2013/10/31 17:19:35 This is no longer strictly true. You can say "salt
perkj_chrome 2013/11/01 13:39:34 logic is now changed. On 2013/10/31 17:19:35, Jói
+ // the IO thread.
+ std::string salt_;
+ mutable StringPrefMember media_device_id_salt_;
+};
+
+#endif // CHROME_BROWSER_MEDIA_MEDIA_DEVICE_ID_SALT_H_

Powered by Google App Engine
This is Rietveld 408576698