chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc - Issue 54863002: Implement a salt for MediaSource IDs that can be cleared by a user.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

Issue 54863002: Implement a salt for MediaSource IDs that can be cleared by a user. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comments- unit tests still don't compile Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/media/media_device_id_salt.h » ('j') | chrome/browser/media/media_device_id_salt.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

index 19ab252f4d28821fe9980dce3322d8d578ed716e..d55447eaa041ca3fcbe4faac8e575ab19e80a95e 100644

--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

@@ -284,7 +284,8 @@ std::string WebrtcAudioPrivateGetAssociatedSinkFunction::DoWorkOnDeviceThread(

++it) {

const std::string& id = it->unique_id;

if (content::DoesMediaDeviceIDMatchHMAC(

- security_origin, source_id_in_origin, id)) {

+ GetProfile()->GetResourceContext(), security_origin,

Jói 2013/10/31 17:19:35 One param per line since they don't fit all on one

perkj_chrome 2013/11/01 13:39:34 Done.

+ source_id_in_origin, id)) {

raw_source_id = id;

DVLOG(2) << "Found raw ID " << raw_source_id

<< " for source ID in origin " << source_id_in_origin;