Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 548523004: Fix for no-op assist proposals. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for no-op assist proposals. R=paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 2 chunks +11 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-05 20:38:33 UTC) #1
Paul Berry
lgtm
6 years, 3 months ago (2014-09-05 20:44:05 UTC) #2
scheglov
6 years, 3 months ago (2014-09-05 21:09:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39931 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698