Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: pkg/analysis_server/test/services/correction/assist_test.dart

Issue 548523004: Fix for no-op assist proposals. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/correction/assist_test.dart
diff --git a/pkg/analysis_server/test/services/correction/assist_test.dart b/pkg/analysis_server/test/services/correction/assist_test.dart
index eb5551afa3a27a73dfa658649699ad6cfe2f6033..3648e73680175fd11b47cb85a5ddec8bc075de71 100644
--- a/pkg/analysis_server/test/services/correction/assist_test.dart
+++ b/pkg/analysis_server/test/services/correction/assist_test.dart
@@ -9,9 +9,10 @@ import 'package:analysis_server/src/services/correction/assist.dart';
import 'package:analysis_server/src/services/index/index.dart';
import 'package:analysis_server/src/services/index/local_memory_index.dart';
import 'package:analysis_server/src/services/search/search_engine_internal.dart';
+import 'package:unittest/unittest.dart';
+
import '../../abstract_single_unit.dart';
import '../../reflective_tests.dart';
-import 'package:unittest/unittest.dart';
main() {
@@ -1713,6 +1714,15 @@ var v = true ? 111 : 222;
assertNoAssistAt('? 111', AssistKind.REPLACE_CONDITIONAL_WITH_IF_ELSE);
}
+ void test_replaceConditionalWithIfElse_wrong_notConditional() {
+ _indexTestUnit('''
+main() {
+ var v = 42;
+}
+''');
+ assertNoAssistAt('v = 42', AssistKind.REPLACE_CONDITIONAL_WITH_IF_ELSE);
+ }
+
void test_replaceIfElseWithConditional_OK_assignment() {
_indexTestUnit('''
main() {

Powered by Google App Engine
This is Rietveld 408576698