Added 24k sample rate support and removed the validation check in webrtc

Added 24k sample rate support and removed the validation check in webrtc. Our resampler is able to handle whatever hardware sample rate.

BUG=411241
COLLABORATOR=tommi@chromium.org

[no longer working on chromium, 2014-09-05 13:05:28]

xians@chromium.org changed reviewers:
+ dalecurtis@chromium.org, henrika@chromium.org

[no longer working on chromium, 2014-09-05 13:05:42]

Henrik and Dale, please take a look.

[henrika (OOO until Aug 14), 2014-09-05 13:08:28]

LGTM

https://codereview.chromium.org/548503002/diff/1/content/renderer/media/webrt...
File content/renderer/media/webrtc_audio_capturer.cc (right):

https://codereview.chromium.org/548503002/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc_audio_capturer.cc:175: if
(media::ToAudioSampleRate(device_info_.device.input.sample_rate, &asr)) {
Still valid to populate this histogram, right?

[no longer working on chromium, 2014-09-05 13:11:58]

https://codereview.chromium.org/548503002/diff/1/content/renderer/media/webrt...
File content/renderer/media/webrtc_audio_capturer.cc (right):

https://codereview.chromium.org/548503002/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc_audio_capturer.cc:175: if
(media::ToAudioSampleRate(device_info_.device.input.sample_rate, &asr)) {
On 2014/09/05 13:08:28, henrika wrote:
> Still valid to populate this histogram, right?

Yes, we would like to keep the uma.

[DaleCurtis, 2014-09-05 17:27:46]

https://codereview.chromium.org/548503002/diff/1/media/audio/sample_rates.h
File media/audio/sample_rates.h (right):

https://codereview.chromium.org/548503002/diff/1/media/audio/sample_rates.h#n...
media/audio/sample_rates.h:28: kAudioSampleRateMax = k192000Hz,
You need to change this.

[tommi (sloooow) - chröme, 2014-09-05 19:17:20]

https://codereview.chromium.org/548503002/diff/1/media/audio/sample_rates.h
File media/audio/sample_rates.h (right):

https://codereview.chromium.org/548503002/diff/1/media/audio/sample_rates.h#n...
media/audio/sample_rates.h:28: kAudioSampleRateMax = k192000Hz,
On 2014/09/05 17:27:45, DaleCurtis wrote:
> You need to change this.

I think k192000Hz is still the highest value.  The 24000 value is just out of
order now :-/

[DaleCurtis, 2014-09-05 19:19:55]

https://codereview.chromium.org/548503002/diff/1/media/audio/sample_rates.h
File media/audio/sample_rates.h (right):

https://codereview.chromium.org/548503002/diff/1/media/audio/sample_rates.h#n...
media/audio/sample_rates.h:28: kAudioSampleRateMax = k192000Hz,
On 2014/09/05 19:17:20, tommi wrote:
> On 2014/09/05 17:27:45, DaleCurtis wrote:
> > You need to change this.
> 
> I think k192000Hz is still the highest value.  The 24000 value is just out of
> order now :-/

It still needs to be changed otherwise the UMA reporting won't bucket correctly.
 I don't think anything uses this value as the actual max sample rate.  |value|
in this case refers to the assigned enum value.

[tommi (sloooow) - chröme, 2014-09-05 20:08:46]

https://codereview.chromium.org/548503002/diff/1/media/audio/sample_rates.h
File media/audio/sample_rates.h (right):

https://codereview.chromium.org/548503002/diff/1/media/audio/sample_rates.h#n...
media/audio/sample_rates.h:28: kAudioSampleRateMax = k192000Hz,
On 2014/09/05 19:19:55, DaleCurtis wrote:
> On 2014/09/05 19:17:20, tommi wrote:
> > On 2014/09/05 17:27:45, DaleCurtis wrote:
> > > You need to change this.
> > 
> > I think k192000Hz is still the highest value.  The 24000 value is just out
of
> > order now :-/
> 
> It still needs to be changed otherwise the UMA reporting won't bucket
correctly.
>  I don't think anything uses this value as the actual max sample rate. 
|value|
> in this case refers to the assigned enum value.

Ah of course. This is easy to misread :)

[DaleCurtis, 2014-09-05 23:17:15]

To avoid time-zone churn, lgtm % the fixing the UMA stat issue.

[tommi (sloooow) - chröme, 2014-09-08 16:18:22]

On 2014/09/05 23:17:15, DaleCurtis wrote:
> To avoid time-zone churn, lgtm % the fixing the UMA stat issue.

I thought we had landed this, so I'm going ahead with landing it now in a
separate issue:
https://codereview.chromium.org/554733002

[no longer working on chromium, 2014-09-09 12:20:39]

On 2014/09/08 16:18:22, tommi wrote:
> On 2014/09/05 23:17:15, DaleCurtis wrote:
> > To avoid time-zone churn, lgtm % the fixing the UMA stat issue.
> 
> I thought we had landed this, so I'm going ahead with landing it now in a
> separate issue:
> https://codereview.chromium.org/554733002

I am going to close this CL correspondingly.