Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 554733002: Add support for 24kHz audio sample rate and remove the validation check (Closed)

Created:
6 years, 3 months ago by tommi (sloooow) - chröme
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for 24kHz audio sample rate and remove the validation check in webrtc. Our resampler is capable of handling any sample rates. This has been reviewed here: https://codereview.chromium.org/548503002/ BUG=411241 TBR=xians,dalecurtis NOTRY=true Committed: https://crrev.com/50c219e6a3219aa278d96ab5a8f89a8abe24b4e5 Cr-Commit-Position: refs/heads/master@{#293773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -56 lines) Patch
M content/renderer/media/webrtc_audio_capturer.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M content/renderer/media/webrtc_audio_renderer.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M media/audio/sample_rates.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/sample_rates.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
tommi (sloooow) - chröme
6 years, 3 months ago (2014-09-08 16:20:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/554733002/1
6 years, 3 months ago (2014-09-08 16:30:17 UTC) #4
no longer working on chromium
lgtm Thanks, I was in barnakut this afternoon, otherwise I would have landed my CL.
6 years, 3 months ago (2014-09-08 16:52:51 UTC) #5
tommi (sloooow) - chröme
On 2014/09/08 16:52:51, xians1 wrote: > lgtm > Thanks, I was in barnakut this afternoon, ...
6 years, 3 months ago (2014-09-08 17:06:20 UTC) #6
DaleCurtis
lgtm
6 years, 3 months ago (2014-09-08 17:40:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/3042) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2862) android_dbg_tests_recipe ...
6 years, 3 months ago (2014-09-08 19:38:43 UTC) #9
tommi (sloooow) - chröme
On 2014/09/08 19:38:43, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-09-08 19:50:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/554733002/1
6 years, 3 months ago (2014-09-08 19:52:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 70018e1b7958533aefb3427d111bf483b432e909
6 years, 3 months ago (2014-09-08 19:57:29 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50c219e6a3219aa278d96ab5a8f89a8abe24b4e5
Cr-Commit-Position: refs/heads/master@{#293773}

Powered by Google App Engine
This is Rietveld 408576698