chrome/browser/signin/local_auth_unittest.cc - Issue 548393002: Enable lock even when no password hash is present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/local_auth_unittest.cc

Issue 548393002: Enable lock even when no password hash is present. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remote AuthCredsExist check Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/local_auth_unittest.cc

diff --git a/chrome/browser/signin/local_auth_unittest.cc b/chrome/browser/signin/local_auth_unittest.cc

index 2da9b74cc3411b438ab772ae44e24da8afc059f7..e1fd26c642d8cccefecdfe9f68c85d81ae301b4d 100644

--- a/chrome/browser/signin/local_auth_unittest.cc

+++ b/chrome/browser/signin/local_auth_unittest.cc

@@ -35,9 +35,7 @@ TEST(LocalAuthTest, SetAndCheckCredentials) {

std::string password("Some Password");

EXPECT_FALSE(ValidateLocalAuthCredentials(prof, password));

- EXPECT_FALSE(LocalAuthCredentialsExist(prof));

SetLocalAuthCredentials(prof, password);

- EXPECT_TRUE(LocalAuthCredentialsExist(prof));

msw 2014/09/09 16:52:56 You can keep/move the functions if they're truly v

std::string passhash = cache.GetLocalAuthCredentialsOfProfileAtIndex(0);

// We perform basic validation on the written record to ensure bugs don't slip