Enable lock even when no password hash is present.

chrome/browser/signin/local_auth_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/local_auth.h"
 
 #include "base/base64.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/pref_names.h"
@@ skipping 17 matching lines @@
   EXPECT_EQ(1U, cache.GetNumberOfProfiles());
   EXPECT_EQ("", cache.GetLocalAuthCredentialsOfProfileAtIndex(0));
 
 #if defined(OS_MACOSX)
   OSCrypt::UseMockKeychain(true);
 #endif
 
   std::string password("Some Password");
   EXPECT_FALSE(ValidateLocalAuthCredentials(prof, password));
 
-  EXPECT_FALSE(LocalAuthCredentialsExist(prof));
   SetLocalAuthCredentials(prof, password);
-  EXPECT_TRUE(LocalAuthCredentialsExist(prof));

[msw, 2014/09/09 16:52:56]

You can keep/move the functions if they're truly valuable here.

   std::string passhash = cache.GetLocalAuthCredentialsOfProfileAtIndex(0);
 
   // We perform basic validation on the written record to ensure bugs don't slip
   // in that cannot be seen from the API:
   //  - The encoding exists (we can guarantee future backward compatibility).
   //  - The plaintext version of the password is not mistakenly stored anywhere.
   EXPECT_FALSE(passhash.empty());
   EXPECT_EQ('1', passhash[0]);
   EXPECT_EQ(passhash.find(password), std::string::npos);
 
   std::string decodedhash;
   base::Base64Decode(passhash.substr(1), &decodedhash);
   EXPECT_FALSE(decodedhash.empty());
   EXPECT_EQ(decodedhash.find(password), std::string::npos);
 
   EXPECT_TRUE(ValidateLocalAuthCredentials(prof, password));
   EXPECT_FALSE(ValidateLocalAuthCredentials(prof, password + "1"));
 
   SetLocalAuthCredentials(prof, password);  // makes different salt
   EXPECT_NE(passhash, cache.GetLocalAuthCredentialsOfProfileAtIndex(0));
 }