Move AttachmentStore ownership to datatype

components/sync_driver/generic_change_processor_factory.cc

Index: components/sync_driver/generic_change_processor_factory.cc
diff --git a/components/sync_driver/generic_change_processor_factory.cc b/components/sync_driver/generic_change_processor_factory.cc
index 7288049c91a5c08d6f7d4eed9ebe4275aae02179..501e699389023e88b79f26ea7f08bf93dd130b84 100644
--- a/components/sync_driver/generic_change_processor_factory.cc
+++ b/components/sync_driver/generic_change_processor_factory.cc
@@ -5,6 +5,7 @@
 #include "components/sync_driver/generic_change_processor_factory.h"
 
 #include "components/sync_driver/generic_change_processor.h"
+#include "sync/api/syncable_service.h"
 
 namespace sync_driver {
 
@@ -21,11 +22,13 @@ GenericChangeProcessorFactory::CreateGenericChangeProcessor(
     const base::WeakPtr<syncer::SyncMergeResult>& merge_result,
     SyncApiComponentFactory* sync_factory) {
   DCHECK(user_share);
-  return make_scoped_ptr(new GenericChangeProcessor(error_handler,
-                                                    local_service,
-                                                    merge_result,
-                                                    user_share,
-                                                    sync_factory)).Pass();
+  return make_scoped_ptr(new GenericChangeProcessor(
+                             error_handler,
+                             local_service,
+                             merge_result,
+                             user_share,
+                             sync_factory,
+                             local_service->GetAttachmentStore())).Pass();

[maniscalco, 2014/09/08 21:56:34]

Can you confirm that this method (CreateGenericChangeProcess) is called on the
datatype's thread?  I believe it is, but we should make sure since we're
dereferencing the local_service WeakPtr.

[maniscalco, 2014/09/08 21:56:34]

Any situations where local_service could be null at this point?  If so, we
should probably be checking for null and passing in a null
scoped_refptr<AttachmentStore>.

 }
 
 }  // namespace sync_driver