Move AttachmentStore ownership to datatype

components/sync_driver/generic_change_processor_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync_driver/generic_change_processor_factory.h"
 
 #include "components/sync_driver/generic_change_processor.h"
+#include "sync/api/syncable_service.h"
 
 namespace sync_driver {
 
 
 GenericChangeProcessorFactory::GenericChangeProcessorFactory() {}
 
 GenericChangeProcessorFactory::~GenericChangeProcessorFactory() {}
 
 scoped_ptr<GenericChangeProcessor>
 GenericChangeProcessorFactory::CreateGenericChangeProcessor(
     syncer::UserShare* user_share,
     DataTypeErrorHandler* error_handler,
     const base::WeakPtr<syncer::SyncableService>& local_service,
     const base::WeakPtr<syncer::SyncMergeResult>& merge_result,
     SyncApiComponentFactory* sync_factory) {
   DCHECK(user_share);
-  return make_scoped_ptr(new GenericChangeProcessor(error_handler,
-                                                    local_service,
-                                                    merge_result,
-                                                    user_share,
-                                                    sync_factory)).Pass();
+  return make_scoped_ptr(new GenericChangeProcessor(
+                             error_handler,
+                             local_service,
+                             merge_result,
+                             user_share,
+                             sync_factory,
+                             local_service->GetAttachmentStore())).Pass();

[maniscalco, 2014/09/08 21:56:34]

Can you confirm that this method (CreateGenericChangeProcess) is called on the
datatype's thread?  I believe it is, but we should make sure since we're
dereferencing the local_service WeakPtr.

[maniscalco, 2014/09/08 21:56:34]

Any situations where local_service could be null at this point?  If so, we
should probably be checking for null and passing in a null
scoped_refptr<AttachmentStore>.

 }
 
 }  // namespace sync_driver