Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 548323002: DevTools: Blackbox content scripts - frontend. (Closed)

Created:
6 years, 3 months ago by aandrey
Modified:
6 years, 3 months ago
Reviewers:
vsevik, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Blackbox content scripts - frontend. BUG=160207 R=vsevik, yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181961

Patch Set 1 #

Patch Set 2 : added a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -34 lines) Patch
A LayoutTests/inspector/sources/debugger/frameworks-blackbox-patterns.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/frameworks-blackbox-patterns-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/devtools/front_end/bindings/Linkifier.js View 1 chunk +7 lines, -1 line 0 comments Download
M Source/devtools/front_end/common/Settings.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +6 lines, -1 line 0 comments Download
M Source/devtools/front_end/helpScreen.css View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/BlackboxSupport.js View 1 5 chunks +52 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 3 chunks +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/settings/FrameworkBlackboxDialog.js View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/settings/SettingsScreen.js View 5 chunks +27 lines, -7 lines 0 comments Download
M Source/devtools/front_end/sources/CallStackSidebarPane.js View 3 chunks +23 lines, -15 lines 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 4 chunks +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
aandrey
6 years, 3 months ago (2014-09-08 14:27:21 UTC) #1
aandrey
ping?
6 years, 3 months ago (2014-09-10 11:49:54 UTC) #2
yurys
lgtm
6 years, 3 months ago (2014-09-14 17:10:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/548323002/20001
6 years, 3 months ago (2014-09-14 18:54:47 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-14 19:55:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181961

Powered by Google App Engine
This is Rietveld 408576698