Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Unified Diff: Source/devtools/front_end/settings/SettingsScreen.js

Issue 548323002: DevTools: Blackbox content scripts - frontend. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: added a test Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/settings/SettingsScreen.js
diff --git a/Source/devtools/front_end/settings/SettingsScreen.js b/Source/devtools/front_end/settings/SettingsScreen.js
index bbe2f7015900c8c8297b62e66ab46863caa3cfeb..2e337bcc304c6dfeef1db02d4277aa0524ff8f33 100644
--- a/Source/devtools/front_end/settings/SettingsScreen.js
+++ b/Source/devtools/front_end/settings/SettingsScreen.js
@@ -891,9 +891,7 @@ WebInspector.EditableSettingsList.prototype = {
var columnId = column.id;
var value = this._valuesProvider(itemId, columnId);
- var textElement = this._textElements.get(itemId).get(columnId);
- textElement.textContent = value;
- textElement.title = value;
+ this._setTextElementContent(itemId, columnId, value);
var editElement = this._editInputElements.get(itemId).get(columnId);
this._setEditElementValue(editElement, value || "");
@@ -901,6 +899,29 @@ WebInspector.EditableSettingsList.prototype = {
},
/**
+ * @param {?string} itemId
+ * @param {string} columnId
+ */
+ _textElementContent: function(itemId, columnId)
+ {
+ if (!itemId)
+ return "";
+ return this._textElements.get(itemId).get(columnId).textContent.replace(/\u200B/g, "");
+ },
+
+ /**
+ * @param {string} itemId
+ * @param {string} columnId
+ * @param {string} text
+ */
+ _setTextElementContent: function(itemId, columnId, text)
+ {
+ var textElement = this._textElements.get(itemId).get(columnId);
+ textElement.textContent = text.replace(/.{4}/g, "$&\u200B");
+ textElement.title = text;
+ },
+
+ /**
* @param {!Element} columnElement
* @param {{id: string, placeholder: (string|undefined), options: (!Array.<string>|undefined)}} column
* @param {?string} itemId
@@ -922,10 +943,9 @@ WebInspector.EditableSettingsList.prototype = {
var value = this._valuesProvider(itemId, columnId);
var textElement = /** @type {!HTMLSpanElement} */ (columnElement.createChild("span", "list-column-text"));
- textElement.textContent = value;
- textElement.title = value;
columnElement.addEventListener("click", rowClicked.bind(this), false);
this._textElements.get(itemId).set(columnId, textElement);
+ this._setTextElementContent(itemId, columnId, value);
this._createEditElement(columnElement, column, itemId, value);
@@ -1056,7 +1076,7 @@ WebInspector.EditableSettingsList.prototype = {
var columns = this.columns();
for (var i = 0; i < columns.length; ++i) {
var columnId = columns[i];
- var oldValue = itemId ? this._textElements.get(itemId).get(columnId).textContent : "";
+ var oldValue = this._textElementContent(itemId, columnId);
var newValue = this._inputElements(itemId).get(columnId).value;
if (oldValue !== newValue)
return true;
@@ -1091,7 +1111,7 @@ WebInspector.EditableSettingsList.prototype = {
for (var i = 0; i < columns.length; ++i) {
var columnId = columns[i];
var editElement = this._editInputElements.get(itemId).get(columnId);
- this._setEditElementValue(editElement, this._textElements.get(itemId).get(columnId).textContent);
+ this._setEditElementValue(editElement, this._textElementContent(itemId, columnId));
editElement.classList.remove("editable-item-error");
}
return;

Powered by Google App Engine
This is Rietveld 408576698