Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 548303003: Revert of Removing X11 native_event uses for key events. (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tdresser+watch_chromium.org, nasko+codewatch_chromium.org, jam, sadrul, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, ben+ash_chromium.org, Elliot Glaysher
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Removing X11 native_event uses for key events. (patchset #7 id:180001 of https://codereview.chromium.org/479873002/) Reason for revert: Broke Android Tests (dbg) C 427.575s Main [FAIL] org.chromium.content.browser.input.ImeTest#testKeyCodesWhileComposingText: C 427.575s Main junit.framework.AssertionFailedError C 427.575s Main at org.chromium.content.browser.input.ImeTest.assertUpdateStateCall(ImeTest.java:694) C 427.575s Main at org.chromium.content.browser.input.ImeTest.testKeyCodesWhileComposingText(ImeTest.java:410) C 427.575s Main at java.lang.reflect.Method.invokeNative(Native Method) C 427.575s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 427.575s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 427.575s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 427.575s Main at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227) C 427.575s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 427.575s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 427.575s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) C 427.575s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701) Original issue's description: > Removing uses of X11 native key events. > > BUG=380349 > > Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822 > > Committed: https://chromium.googlesource.com/chromium/src/+/13d90b146a400156427243d05159cadd8d72c0b9 TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,boliu@chromium.org,kpschoedel@chromium.org NOTREECHECKS=true NOTRY=true BUG=380349 Committed: https://crrev.com/1125c1167a776f1da2a9196a12b40c91ffee04af Cr-Commit-Position: refs/heads/master@{#293732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -185 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/accelerators/key_hold_detector.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 4 chunks +30 lines, -11 lines 0 comments Download
A content/browser/renderer_host/web_input_event_aurax11.cc View 1 chunk +96 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 2 chunks +14 lines, -11 lines 0 comments Download
M mojo/services/native_viewport/platform_viewport_x11.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/input_events/lib/input_events_type_converters.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M ui/events/event.h View 5 chunks +2 lines, -31 lines 0 comments Download
M ui/events/event.cc View 7 chunks +7 lines, -110 lines 0 comments Download
M ui/events/event_utils.h View 2 chunks +19 lines, -4 lines 0 comments Download
M ui/events/event_utils.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/ozone/events_ozone.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/events/win/events_win.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
Created Revert of Removing X11 native_event uses for key events.
6 years, 3 months ago (2014-09-08 15:38:38 UTC) #1
arv (Not doing code reviews)
FY keishi
6 years, 3 months ago (2014-09-08 15:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/548303003/1
6 years, 3 months ago (2014-09-08 15:39:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 08456d963f10ddd4e2c9a38cf97c94bceb2b1d0c
6 years, 3 months ago (2014-09-08 15:41:58 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1125c1167a776f1da2a9196a12b40c91ffee04af
Cr-Commit-Position: refs/heads/master@{#293732}

Powered by Google App Engine
This is Rietveld 408576698