Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 548223003: cc: Block drawing of tiles without twins. (Closed)

Created:
6 years, 3 months ago by sohanjg
Modified:
6 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Block drawing of tiles without twins. When there is a race between activation+drawing and rasterizing, for tiles without twins, we should prevent the active tree from drawing these tiles. BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -14 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +7 lines, -0 lines 1 comment Download
M cc/resources/picture_layer_tiling.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 3 chunks +33 lines, -14 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
sohanjg
Can you please take a look, thanks!
6 years, 3 months ago (2014-09-08 10:08:05 UTC) #2
sohanjg
https://codereview.chromium.org/548223003/diff/1/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/548223003/diff/1/cc/layers/picture_layer_impl.cc#newcode874 cc/layers/picture_layer_impl.cc:874: layer_tree_impl()->SetRequiresHighResToDraw(); we should SetRequiresHighResToDraw, on the twin layer impl ...
6 years, 3 months ago (2014-09-08 13:45:16 UTC) #3
sohanjg
https://codereview.chromium.org/548223003/diff/1/cc/trees/layer_tree_host_unittest_context.cc File cc/trees/layer_tree_host_unittest_context.cc (right): https://codereview.chromium.org/548223003/diff/1/cc/trees/layer_tree_host_unittest_context.cc#newcode334 cc/trees/layer_tree_host_unittest_context.cc:334: Are we drawing/recording this too far away from visible ...
6 years, 3 months ago (2014-09-08 15:17:32 UTC) #4
sohanjg
6 years, 3 months ago (2014-09-09 09:21:01 UTC) #5
Message was sent while issue was closed.
We will track it as part of https://codereview.chromium.org/475633008/

Powered by Google App Engine
This is Rietveld 408576698