Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 548223002: Web-Animations: Implement idle state for AnimationPlayers (Closed)

Created:
6 years, 3 months ago by dstockwell
Modified:
6 years, 3 months ago
Reviewers:
shans
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Project:
blink
Visibility:
Public.

Description

Web-Animations: Implement idle state for AnimationPlayers Refactor AnimationPlayer::cancel() to enter idle state rather than nullifying m_source. Original patch[1] by shans@chromium.org [1] https://codereview.chromium.org/534193002 BUG=396366 TBR=shans@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181564

Patch Set 1 #

Patch Set 2 : Pass null inherited time when idle. #

Patch Set 3 : Update inherited time while idle. Current Time in finish event is unresolved when cancelled. #

Patch Set 4 : Use known current time in finish event #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -19 lines) Patch
M LayoutTests/web-animations-api/player-cancel-finishes.html View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/Animation.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 2 chunks +13 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 2 3 11 chunks +31 lines, -12 lines 0 comments Download
M Source/core/animation/AnimationPlayerTest.cpp View 3 chunks +99 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dstockwell
6 years, 3 months ago (2014-09-08 05:21:37 UTC) #2
shans
lgtm
6 years, 3 months ago (2014-09-08 08:35:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/548223002/60001
6 years, 3 months ago (2014-09-08 08:35:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26000)
6 years, 3 months ago (2014-09-08 11:37:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/548223002/60001
6 years, 3 months ago (2014-09-08 11:42:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26016)
6 years, 3 months ago (2014-09-08 13:59:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/548223002/60001
6 years, 3 months ago (2014-09-08 14:29:35 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 15:07:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 181564

Powered by Google App Engine
This is Rietveld 408576698