Web-Animations: Implement idle state for AnimationPlayers.

Web-Animations: Implement idle state for AnimationPlayers.
Refactor AnimationPlayer::cancel() to enter idle state rather than nullifying m_source.

BUG=396366

[shans, 2014-09-03 11:20:28]

shans@chromium.org changed reviewers:
+ dstockwell@chromium.org

[dstockwell, 2014-09-04 00:34:06]

https://codereview.chromium.org/534193002/diff/1/Source/core/animation/Animat...
File Source/core/animation/AnimationPlayerTest.cpp (right):

https://codereview.chromium.org/534193002/diff/1/Source/core/animation/Animat...
Source/core/animation/AnimationPlayerTest.cpp:825: EXPECT_EQ(0,
player->currentTime());
What should happen when the playback rate is negative?

[shans, 2014-09-04 03:50:35]

On 2014/09/04 00:34:06, dstockwell wrote:
>
https://codereview.chromium.org/534193002/diff/1/Source/core/animation/Animat...
> File Source/core/animation/AnimationPlayerTest.cpp (right):
> 
>
https://codereview.chromium.org/534193002/diff/1/Source/core/animation/Animat...
> Source/core/animation/AnimationPlayerTest.cpp:825: EXPECT_EQ(0,
> player->currentTime());
> What should happen when the playback rate is negative?

The animation will run from endSource to 0. See the new test for clarification.

[dstockwell, 2014-09-08 00:57:24]

The CQ bit was checked by dstockwell@chromium.org

[dstockwell, 2014-09-08 00:57:24]

lgtm

[commit-bot: I haz the power, 2014-09-08 00:58:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/shans@chromium.org/534193002/20001

[commit-bot: I haz the power, 2014-09-08 00:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 00:58:20]

Failed to apply patch for Source/core/animation/AnimationPlayer.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/animation/AnimationPlayer.cpp
  Hunk #2 FAILED at 70.
  Hunk #3 succeeded at 151 (offset -1 lines).
  Hunk #4 succeeded at 359 (offset -1 lines).
  Hunk #5 succeeded at 390 (offset -1 lines).
  Hunk #6 succeeded at 436 (offset -1 lines).
  Hunk #7 succeeded at 453 (offset -1 lines).
  Hunk #8 succeeded at 481 (offset -1 lines).
  Hunk #9 succeeded at 606 (offset -1 lines).
  Hunk #10 succeeded at 624 (offset -1 lines).
  Hunk #11 succeeded at 641 (offset -1 lines).
  1 out of 11 hunks FAILED -- saving rejects to file
Source/core/animation/AnimationPlayer.cpp.rej

Patch:       Source/core/animation/AnimationPlayer.cpp
Index: Source/core/animation/AnimationPlayer.cpp
diff --git a/Source/core/animation/AnimationPlayer.cpp
b/Source/core/animation/AnimationPlayer.cpp
index
0e3f917380346ec77bd233305db755d29cf46bce..3c84a397aa0dbb5ebf9dd0da207776c7b0d4ce91
100644
--- a/Source/core/animation/AnimationPlayer.cpp
+++ b/Source/core/animation/AnimationPlayer.cpp
@@ -52,6 +52,7 @@ static unsigned nextSequenceNumber()
 PassRefPtrWillBeRawPtr<AnimationPlayer>
AnimationPlayer::create(ExecutionContext* executionContext, AnimationTimeline&
timeline, AnimationNode* content)
 {
     RefPtrWillBeRawPtr<AnimationPlayer> player = adoptRefWillBeNoop(new
AnimationPlayer(executionContext, timeline, content));
+    player->uncancel();
     timeline.document()->compositorPendingAnimations().add(player.get());
     player->suspendIfNeeded();
     return player.release();
@@ -69,15 +70,18 @@ AnimationPlayer::AnimationPlayer(ExecutionContext*
executionContext, AnimationTi
     , m_held(true)
     , m_isPausedForTesting(false)
     , m_outdated(true)
-    , m_finished(false)
+    , m_finished(true)
     , m_compositorState(nullptr)
     , m_compositorPending(true)
     , m_currentTimePending(false)
+    , m_idle(true)
 {
     ScriptWrappable::init(this);
     if (m_content) {
-        if (m_content->player())
+        if (m_content->player()) {
             m_content->player()->cancel();
+            m_content->player()->setSource(0);
+        }
         m_content->attach(this);
     }
 }
@@ -151,7 +155,7 @@ double AnimationPlayer::startTime() const
 
 double AnimationPlayer::currentTime()
 {
-    if (m_currentTimePending)
+    if (m_currentTimePending || m_idle)
         return std::numeric_limits<double>::quiet_NaN();
     return currentTimeInternal() * 1000;
 }
@@ -359,8 +363,10 @@ void AnimationPlayer::setSource(AnimationNode* newSource)
     m_content = newSource;
     if (newSource) {
         // FIXME: This logic needs to be updated once groups are implemented
-        if (newSource->player())
+        if (newSource->player()) {
             newSource->player()->cancel();
+            newSource->player()->setSource(0);
+        }
         newSource->attach(this);
         setOutdated();
     }
@@ -388,10 +394,10 @@ String AnimationPlayer::playState()
 
 AnimationPlayer::AnimationPlayState AnimationPlayer::playStateInternal()
 {
-    // FIXME(shanestephens): Add clause for in-idle-state here.
+    if (m_idle)
+        return Idle;
     if (m_currentTimePending || (isNull(m_startTime) && !m_paused &&
m_playbackRate != 0))
         return Pending;
-    // FIXME(shanestephens): Add idle handling here.
     if (m_paused)
         return Paused;
     if (finished())
@@ -434,6 +440,7 @@ void AnimationPlayer::play()
         m_startTime = nullValue();
 
     setCompositorPending();
+    uncancel();
     unpauseInternal();
     if (!m_content)
         return;
@@ -450,6 +457,9 @@ void AnimationPlayer::reverse()
     if (!m_playbackRate) {
         return;
     }
+
+    uncancel();
+
     if (m_content) {
         if (m_playbackRate > 0 && currentTimeInternal() > sourceEnd()) {
             setCurrentTimeInternal(sourceEnd(), TimingUpdateOnDemand);
@@ -475,6 +485,10 @@ void AnimationPlayer::finish(ExceptionState&
exceptionState)
     if (playing()) {
         setCompositorPending();
     }
+
+    uncancel();
+    m_startTime = 0;
+
     if (m_playbackRate < 0) {
         setCurrentTimeInternal(0, TimingUpdateOnDemand);
     } else {
@@ -596,13 +610,13 @@ bool AnimationPlayer::update(TimingUpdateReason reason)
     updateCurrentTimingState(reason);
     m_outdated = false;
 
-    if (m_content) {
+    if (m_content && !m_idle) {
         double inheritedTime = isNull(m_timeline->currentTimeInternal()) ?
nullValue() : currentTimeInternal();
         m_content->updateInheritedTime(inheritedTime, reason);
     }
 
-    if (finished() && !m_finished) {
-        if (reason == TimingUpdateForAnimationFrame && hasStartTime()) {
+    if ((m_idle || finished()) && !m_finished) {
+        if (reason == TimingUpdateForAnimationFrame && (m_idle ||
hasStartTime())) {
             const AtomicString& eventType = EventTypeNames::finish;
             if (executionContext() && hasEventListeners(eventType)) {
                 m_pendingFinishedEvent =
AnimationPlayerEvent::create(eventType, currentTime(),
timeline()->currentTime());
@@ -614,7 +628,7 @@ bool AnimationPlayer::update(TimingUpdateReason reason)
         }
     }
     ASSERT(!m_outdated);
-    return !m_finished || !finished();
+    return !m_finished;
 }
 
 double AnimationPlayer::timeToEffectChange()
@@ -631,7 +645,9 @@ double AnimationPlayer::timeToEffectChange()
 
 void AnimationPlayer::cancel()
 {
-    setSource(0);
+    m_idle = true;
+    m_startTime = nullValue();
+    setCompositorPending();
 }
 
 #if !ENABLE(OILPAN)