Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 548133002: [TTS] Adjust WeakPtr lifetime to object lifetime of TtsMessageFilter (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@tts_leak
Project:
chromium
Visibility:
Public.

Description

[TTS] Adjust WeakPtr lifetime to object lifetime of TtsMessageFilter BUG=393634 Committed: https://crrev.com/72fb7984fa9d6bf0b75560a2b04eca1c431e2685 Cr-Commit-Position: refs/heads/master@{#293683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M chrome/browser/speech/tts_message_filter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/speech/tts_message_filter.cc View 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tzik
PTL
6 years, 3 months ago (2014-09-07 05:46:41 UTC) #2
dmazzoni
lgtm
6 years, 3 months ago (2014-09-08 04:43:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/548133002/1
6 years, 3 months ago (2014-09-08 05:15:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b1b170ccfb203a4734c24e4d3347021d710b5a99
6 years, 3 months ago (2014-09-08 07:11:14 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:44:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72fb7984fa9d6bf0b75560a2b04eca1c431e2685
Cr-Commit-Position: refs/heads/master@{#293683}

Powered by Google App Engine
This is Rietveld 408576698