Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: chrome/browser/speech/tts_message_filter.h

Issue 548133002: [TTS] Adjust WeakPtr lifetime to object lifetime of TtsMessageFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tts_leak
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/speech/tts_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/speech/tts_message_filter.h
diff --git a/chrome/browser/speech/tts_message_filter.h b/chrome/browser/speech/tts_message_filter.h
index cecb2ba6dc32dc698fa2403e9ffa2ecde4b17ffc..8059778a91fffa8d3b190a443c546e5b7d159a4a 100644
--- a/chrome/browser/speech/tts_message_filter.h
+++ b/chrome/browser/speech/tts_message_filter.h
@@ -17,8 +17,7 @@ class BrowserContext;
class TtsMessageFilter
: public content::BrowserMessageFilter,
public UtteranceEventDelegate,
- public VoicesChangedDelegate,
- public base::SupportsWeakPtr<TtsMessageFilter> {
+ public VoicesChangedDelegate {
public:
explicit TtsMessageFilter(int render_process_id,
content::BrowserContext* browser_context);
@@ -57,6 +56,8 @@ class TtsMessageFilter
int render_process_id_;
content::BrowserContext* browser_context_;
+ base::WeakPtrFactory<TtsMessageFilter> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(TtsMessageFilter);
};
« no previous file with comments | « no previous file | chrome/browser/speech/tts_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698