Issue 548067: Allow link drags from the star, bookmarks bar, and bookmark bar menus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 548067: Allow link drags from the star, bookmarks bar, and bookmark bar menus (Closed)

Created:
10 years, 11 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Allow link drags from the star, bookmarks bar, and bookmark bar menus to the Gnome desktop (nautilus). These should create shortcuts. Other drag operations should be the same as before. BUG=24210 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36585

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -27 lines)			Patch
M	app/gtk_dnd_util.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_bar_gtk.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/bookmark_menu_controller_gtk.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_utils_gtk.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/tab_contents_drag_source.cc	View	2 chunks	+5 lines, -16 lines	0 comments	Download
M	chrome/browser/gtk/toolbar_star_toggle_gtk.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

10 years, 11 months ago (2010-01-19 18:06:47 UTC) #2

lgtm

nit: can you be more specific when you say "desktop"---I assume you mean gnome,
i.e. nautilus? I think it already worked in kde.

Expand Messages | Collapse Messages