Allow link drags from the star, bookmarks bar, and bookmark bar menus

chrome/browser/gtk/tab_contents_drag_source.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/tab_contents_drag_source.h"
 
 #include "app/gtk_dnd_util.h"
 #include "base/mime_util.h"
 #include "base/string_util.h"
 #include "chrome/browser/renderer_host/render_view_host_delegate.h"
@@ skipping 109 matching lines @@
     tab_contents()->render_view_host()->DragSourceMovedTo(
         client.x(), client.y(),
         static_cast<int>(event_motion->x_root),
         static_cast<int>(event_motion->y_root));
   }
 }
 
 void TabContentsDragSource::OnDragDataGet(
     GdkDragContext* context, GtkSelectionData* selection_data,
     guint target_type, guint time) {
-  const int bits_per_byte = 8;
+  const int kBitsPerByte = 8;
 
   switch (target_type) {
     case GtkDndUtil::TEXT_PLAIN: {
       std::string utf8_text = UTF16ToUTF8(drop_data_->plain_text);
       gtk_selection_data_set_text(selection_data, utf8_text.c_str(),
                                   utf8_text.length());
       break;
     }
 
     case GtkDndUtil::TEXT_HTML: {
       // TODO(estade): change relative links to be absolute using
       // |html_base_url|.
       std::string utf8_text = UTF16ToUTF8(drop_data_->text_html);
       gtk_selection_data_set(selection_data,
                              GtkDndUtil::GetAtomForTarget(
                                  GtkDndUtil::TEXT_HTML),
-                             bits_per_byte,
+                             kBitsPerByte,
                              reinterpret_cast<const guchar*>(utf8_text.c_str()),
                              utf8_text.length());
       break;
     }
 
     case GtkDndUtil::TEXT_URI_LIST:
-    case GtkDndUtil::CHROME_NAMED_URL: {
+    case GtkDndUtil::CHROME_NAMED_URL:
+    case GtkDndUtil::NETSCAPE_URL: {
       GtkDndUtil::WriteURLWithName(selection_data, drop_data_->url,
                                    drop_data_->url_title, target_type);
       break;
     }
 
-    case GtkDndUtil::NETSCAPE_URL: {
-      // _NETSCAPE_URL format is URL + \n + title.
-      std::string utf8_text = drop_data_->url.spec() + "\n" + UTF16ToUTF8(
-          drop_data_->url_title);
-      gtk_selection_data_set(selection_data,
-                             selection_data->target,
-                             bits_per_byte,
-                             reinterpret_cast<const guchar*>(utf8_text.c_str()),
-                             utf8_text.length());
-      break;
-    }
-
     case GtkDndUtil::CHROME_WEBDROP_FILE_CONTENTS: {
       gtk_selection_data_set(
           selection_data,
-          drag_file_mime_type_, bits_per_byte,
+          drag_file_mime_type_, kBitsPerByte,
           reinterpret_cast<const guchar*>(drop_data_->file_contents.data()),
           drop_data_->file_contents.length());
       break;
     }
 
     default:
       NOTREACHED();
   }
 }
 
@@ skipping 28 matching lines @@
 
   if (tab_contents()->render_view_host())
     tab_contents()->render_view_host()->DragSourceSystemDragEnded();
 
   drop_data_.reset();
 }
 
 gfx::NativeView TabContentsDragSource::GetContentNativeView() const {
   return tab_contents_view_->GetContentNativeView();
 }