Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 54803002: Centralize TextStream functions to remove RenderTreeAsText dependency of the filters (Closed)

Created:
7 years, 1 month ago by rwlbuis
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, danakj, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, Rik, f(malita), jchaffraix+rendering, pdr, bemjb+rendering_chromium.org, Stephen Chennney, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Centralize TextStream functions to remove RenderTreeAsText dependency of the filters BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -98 lines) Patch
M Source/core/platform/graphics/GraphicsLayer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/GraphicsLayer.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/platform/graphics/filters/DistantLightSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEBlend.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEColorMatrix.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEComponentTransfer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEComposite.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEConvolveMatrix.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEDiffuseLighting.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEDisplacementMap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEDropShadow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEFlood.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEGaussianBlur.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEMerge.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEMorphology.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEOffset.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FESpecularLighting.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FETile.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FETurbulence.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/SourceAlpha.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/SourceGraphic.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/filters/custom/FECustomFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTreeAsText.h View 3 chunks +0 lines, -28 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/text/TextStream.h View 2 chunks +32 lines, -0 lines 0 comments Download
M Source/platform/text/TextStream.cpp View 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
Restructuring it like this removes a blocker for the move of the filters/ to Source/platform.
7 years, 1 month ago (2013-10-31 15:02:17 UTC) #1
Stephen Chennney
This is really good. Thanks. LGTM
7 years, 1 month ago (2013-10-31 15:06:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/54803002/1
7 years, 1 month ago (2013-10-31 15:11:52 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=1499
7 years, 1 month ago (2013-10-31 17:27:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/54803002/1
7 years, 1 month ago (2013-10-31 19:28:33 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 20:09:00 UTC) #6
Message was sent while issue was closed. 
Change committed as 161090

Powered by Google App Engine
This is Rietveld 408576698