Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 54793006: telemetry: make mostly_smooth in smoothness metric a float value. (Closed)

Created:
7 years, 1 month ago by ernstm
Modified:
7 years, 1 month ago
Reviewers:
dtu
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

telemetry: make mostly_smooth in smoothness metric a float value. The mostly_smooth metric doesn't show up on the dashboard, because it is a boolean value (False/True). Switch to float (0.0/1.0). R=dtu@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf/metrics/smoothness.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ernstm
PTAL.
7 years, 1 month ago (2013-11-01 22:59:07 UTC) #1
dtu
On 2013/11/01 22:59:07, Manfred Ernst wrote: > PTAL. https://code.google.com/p/chromium/issues/detail?id=305848 :D That aside, I wonder if ...
7 years, 1 month ago (2013-11-02 00:46:21 UTC) #2
ernstm
On 2013/11/02 00:46:21, dtu wrote: > On 2013/11/01 22:59:07, Manfred Ernst wrote: > > PTAL. ...
7 years, 1 month ago (2013-11-02 00:57:03 UTC) #3
dtu
Ah, I think you're right. lgtm
7 years, 1 month ago (2013-11-05 00:12:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/54793006/1
7 years, 1 month ago (2013-11-05 00:44:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/54793006/1
7 years, 1 month ago (2013-11-05 03:13:37 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184741
7 years, 1 month ago (2013-11-05 05:19:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/54793006/1
7 years, 1 month ago (2013-11-05 05:26:02 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 14:10:41 UTC) #9
Message was sent while issue was closed.
Change committed as 232974

Powered by Google App Engine
This is Rietveld 408576698