tools/perf/metrics/smoothness.py - Issue 54793006: telemetry: make mostly_smooth in smoothness metric a float value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/smoothness.py

Issue 54793006: telemetry: make mostly_smooth in smoothness metric a float value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/smoothness.py

diff --git a/tools/perf/metrics/smoothness.py b/tools/perf/metrics/smoothness.py

index b8344442eff0d6868855186b4f7b25e1fc8b3efa..13911d336d1f97656b389cd9ac823e880c522b00 100644

--- a/tools/perf/metrics/smoothness.py

+++ b/tools/perf/metrics/smoothness.py

@@ -84,7 +84,7 @@ class SmoothnessMetric(Metric):

jank = statistics.FrameDiscrepancy(self._stats.frame_timestamps)

results.Add('jank', '', round(jank, 4))

- # Are we hitting 60 fps for 95 percent of all frames? (Boolean value)

+ # Are we hitting 60 fps for 95 percent of all frames?

# We use 17ms as a slightly looser threshold, instead of 1000.0/60.0.

- results.Add('mostly_smooth', '',

- statistics.Percentile(self._stats.frame_times, 95.0) < 17.0)

+ percentile_95 = statistics.Percentile(self._stats.frame_times, 95.0)

+ results.Add('mostly_smooth', '', 1.0 if percentile_95 < 17.0 else 0.0)

« no previous file with comments | « no previous file | no next file » | no next file with comments »