Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands.

Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands.

ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string.

Previously, only the latter case was handled when trying to continue propagating keys.

BUG=407163
TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*).

Committed: https://crrev.com/35e1e6833bc66191e6213080770bdd2f9e8dc34f
Cr-Commit-Position: refs/heads/master@{#293748}

[David Tseng, 2014-09-05 22:18:37]

dtseng@chromium.org changed reviewers:
+ finnur@chromium.org

[David Tseng, 2014-09-05 23:41:56]

Patchset #2 (id:20001) has been deleted

[Finnur, 2014-09-08 15:23:15]

BUG= is wrong. 
Did you mean: issue 407163?

https://codereview.chromium.org/547783002/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_keybinding_registry.cc (left):

https://codereview.chromium.org/547783002/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_keybinding_registry.cc:236: const
std::string& extension_id) {
I wonder if we should add a comment in here, since this is a) a bit subtle, b)
you fell into the trap and c) I failed to catch this (even the wrote this
function)?

[Finnur, 2014-09-08 15:23:28]

Oh, and LGTM.

[David Tseng, 2014-09-08 15:58:34]

Changed to BUG=407163

[David Tseng, 2014-09-08 15:58:41]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-09-08 16:00:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtseng@chromium.org/547783002/1

[commit-bot: I haz the power, 2014-09-08 17:17:08]

Committed patchset #1 (id:1) as 189a2ed4d209231d517b0e64a722722dead3f17a

[arv (Not doing code reviews), 2014-09-08 20:30:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/552533003/ by arv@chromium.org.

The reason for reverting is: Broke Linux ChromiumOS Tests (dbg)(3)

http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tes...

BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace()
#1 0x0000041c884a content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f3bc709f4a0 <unknown>
#3 0x7f3bc7151a43 __poll
#4 0x7f3bc7b8dff6 <unknown>
#5 0x7f3bc7b8e124 g_main_context_iteration
#6 0x7f3bcf366f35 base::MessagePumpGlib::Run()
#7 0x7f3bcf468180 base::MessageLoop::RunHandler()
#8 0x7f3bcf4cfcc2 base::RunLoop::Run()
#9 0x0000041e0729 content::RunThisRunLoop()
#10 0x0000041e06ba content::RunMessageLoop()
#11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult()
#12 0x0000006a30dd
extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread()
#13 0x0000006a3712
extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread()
#14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop()
#15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run()
#17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo()
#18 0x0000041c9c25 base::internal::Invoker<>::Run()
#19 0x00000063f0de base::Callback<>::Run()
#20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun()
#22 0x000002e77daf
chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun()
#24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run()
#25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo()
#26 0x7f3bd7bd960a base::internal::Invoker<>::Run()
#27 0x7f3bd80a852e base::Callback<>::Run()
#28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow()
#29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks()
#30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize()
#31 0x7f3bd7bcda55 content::BrowserMain()
#32 0x7f3bd7a6224f content::RunNamedProcessTypeMain()
#33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run()
#34 0x7f3bd7a617b5 content::ContentMain()
#35 0x0000041c82cb content::BrowserTestBase::SetUp()
#36 0x00000176afc3 InProcessBrowserTest::SetUp()
#37 0x000000674823 ExtensionBrowserTest::SetUp()
#38 0x000000674852 ExtensionBrowserTest::SetUp()
#39 0x0000018298a3 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>()
#41 0x00000180ad73 testing::Test::Run()
#42 0x00000180b4cb testing::TestInfo::Run()
#43 0x00000180baca testing::TestCase::Run()
#44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests()
#45 0x0000018225b3 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>()
#47 0x000001810c97 testing::UnitTest::Run()
#48 0x0000041a5531 RUN_ALL_TESTS()
#49 0x0000041a4547 base::TestSuite::Run()
#50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite()
#51 0x000001769618 (anonymous
namespace)::ChromeTestLauncherDelegate::RunTestSuite()
#52 0x0000041d9efb content::LaunchTests()
#53 0x00000176954b LaunchChromeTests()
#54 0x00000080262f main
#55 0x7f3bc708a76d __libc_start_main
#56 0x0000005ffda9 <unknown>
[123/334] CommandsApiTest.ContinuePropagation (TIMED OUT).

[David Tseng, 2014-09-09 00:02:03]

On 2014/09/08 20:30:27, arv wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/552533003/ by mailto:arv@chromium.org.
> 
> The reason for reverting is: Broke Linux ChromiumOS Tests (dbg)(3)
> 
>
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tes...
> 
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> #0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace()
> #1 0x0000041c884a content::(anonymous
namespace)::DumpStackTraceSignalHandler()
> #2 0x7f3bc709f4a0 <unknown>
> #3 0x7f3bc7151a43 __poll
> #4 0x7f3bc7b8dff6 <unknown>
> #5 0x7f3bc7b8e124 g_main_context_iteration
> #6 0x7f3bcf366f35 base::MessagePumpGlib::Run()
> #7 0x7f3bcf468180 base::MessageLoop::RunHandler()
> #8 0x7f3bcf4cfcc2 base::RunLoop::Run()
> #9 0x0000041e0729 content::RunThisRunLoop()
> #10 0x0000041e06ba content::RunMessageLoop()
> #11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult()
> #12 0x0000006a30dd
> extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread()
> #13 0x0000006a3712
> extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread()
> #14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop()
> #15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
> #16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run()
> #17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo()
> #18 0x0000041c9c25 base::internal::Invoker<>::Run()
> #19 0x00000063f0de base::Callback<>::Run()
> #20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
> #21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun()
> #22 0x000002e77daf
> chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
> #23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun()
> #24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run()
> #25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo()
> #26 0x7f3bd7bd960a base::internal::Invoker<>::Run()
> #27 0x7f3bd80a852e base::Callback<>::Run()
> #28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow()
> #29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks()
> #30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize()
> #31 0x7f3bd7bcda55 content::BrowserMain()
> #32 0x7f3bd7a6224f content::RunNamedProcessTypeMain()
> #33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run()
> #34 0x7f3bd7a617b5 content::ContentMain()
> #35 0x0000041c82cb content::BrowserTestBase::SetUp()
> #36 0x00000176afc3 InProcessBrowserTest::SetUp()
> #37 0x000000674823 ExtensionBrowserTest::SetUp()
> #38 0x000000674852 ExtensionBrowserTest::SetUp()
> #39 0x0000018298a3
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>()
> #41 0x00000180ad73 testing::Test::Run()
> #42 0x00000180b4cb testing::TestInfo::Run()
> #43 0x00000180baca testing::TestCase::Run()
> #44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests()
> #45 0x0000018225b3
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>()
> #47 0x000001810c97 testing::UnitTest::Run()
> #48 0x0000041a5531 RUN_ALL_TESTS()
> #49 0x0000041a4547 base::TestSuite::Run()
> #50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite()
> #51 0x000001769618 (anonymous
> namespace)::ChromeTestLauncherDelegate::RunTestSuite()
> #52 0x0000041d9efb content::LaunchTests()
> #53 0x00000176954b LaunchChromeTests()
> #54 0x00000080262f main
> #55 0x7f3bc708a76d __libc_start_main
> #56 0x0000005ffda9 <unknown>
> [123/334] CommandsApiTest.ContinuePropagation (TIMED OUT).

Very perplexing...only fails on dbg (passes on rel).

[commit-bot: I haz the power, 2014-09-10 03:47:00]

Patchset 1 (id:??) landed as
https://crrev.com/35e1e6833bc66191e6213080770bdd2f9e8dc34f
Cr-Commit-Position: refs/heads/master@{#293748}