Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands.

chrome/browser/extensions/extension_keybinding_registry.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_keybinding_registry.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/active_tab_permission_granter.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 215 matching lines @@
     case PLATFORM_APPS_ONLY:
       return extension->is_platform_app();
     default:
       NOTREACHED();
   }
   return false;
 }
 
 bool ExtensionKeybindingRegistry::ExecuteCommands(
     const ui::Accelerator& accelerator,
     const std::string& extension_id) {

[Finnur, 2014/09/08 15:23:15]

I wonder if we should add a comment in here, since this is a) a bit subtle, b)
you fell into the trap and c) I failed to catch this (even the wrote this
function)?

   EventTargets::iterator targets = event_targets_.find(accelerator);
   if (targets == event_targets_.end() || targets->second.empty())
     return false;
 
-  if (!extension_id.empty() &&
-      !extensions::EventRouter::Get(browser_context_)
-           ->ExtensionHasEventListener(extension_id, kOnCommandEventName))
-    return false;
-
   bool executed = false;
   for (TargetList::const_iterator it = targets->second.begin();
        it != targets->second.end(); it++) {
+    if (!extensions::EventRouter::Get(browser_context_)
+        ->ExtensionHasEventListener(it->first, kOnCommandEventName))
+      continue;
+
     if (extension_id.empty() || it->first == extension_id) {
       CommandExecuted(it->first, it->second);
       executed = true;
     }
   }
 
   return executed;
 }
 
 }  // namespace extensions