Reland of: cc: Add occlusion checker as a fixed view of occlusion tracker.

Reland of: cc: Add occlusion checker as a fixed view of occlusion tracker.

This patch adds an occlusion checker to get the state of
occlusion tracker for permanent checks. That is, occlusion
checker does not have to be queried during a layer walk.

BUG=410932
R=danakj

Committed: https://crrev.com/1af780529157c94a9e0f05bcf478543b85714f6b
Cr-Commit-Position: refs/heads/master@{#294205}

Committed: https://crrev.com/cdcb5f741f8163b771d66f6017a67cff06193b50
Cr-Commit-Position: refs/heads/master@{#294280}

[vmpstr, 2014-09-05 19:24:59]

Hi, could you give this a very early review to just see if we're on the same
page of how this would be used?

Also, I'm kind of working on it with just ::Occluded in mind, which is what my
usecase needs. I figured if we need other things like Unoccluded*, then we can
add that as it evolves.

wdyt?

[danakj, 2014-09-05 19:28:17]

On 2014/09/05 19:24:59, vmpstr wrote:
> Hi, could you give this a very early review to just see if we're on the same
> page of how this would be used?
> 
> Also, I'm kind of working on it with just ::Occluded in mind, which is what my
> usecase needs. I figured if we need other things like Unoccluded*, then we can
> add that as it evolves.
> 
> wdyt?

Occluded() and Unoccluded() are the same thing except in the former we can do
the math in the target space and get a result, in the latter we project the
result back to the content space and don't just return IsEmpty()

[danakj, 2014-09-05 19:31:29]

Ya, seems like the right track

https://codereview.chromium.org/547723002/diff/1/cc/trees/occlusion_checker.h
File cc/trees/occlusion_checker.h (right):

https://codereview.chromium.org/547723002/diff/1/cc/trees/occlusion_checker.h...
cc/trees/occlusion_checker.h:29: gfx::Transform draw_transform_;
This could really be part of the query, the rect + a transform from the rect to
the target. Saving the transform fixes the query space in place, which means
you'd have to map queries for each tiling into the same space, instead of giving
a transform modified by the tiling scale. Idk which is nicer.

https://codereview.chromium.org/547723002/diff/1/cc/trees/occlusion_tracker.cc
File cc/trees/occlusion_tracker.cc (right):

https://codereview.chromium.org/547723002/diff/1/cc/trees/occlusion_tracker.c...
cc/trees/occlusion_tracker.cc:32: LayerType>::GenerateOcclusionChecker(const
LayerType* render_target,
not used, get rid of the render_target parameter.

[vmpstr, 2014-09-05 20:58:57]

PTAL. I will work on adding some tests now.

[vmpstr, 2014-09-05 21:00:06]

https://codereview.chromium.org/547723002/diff/1/cc/trees/occlusion_checker.h
File cc/trees/occlusion_checker.h (right):

https://codereview.chromium.org/547723002/diff/1/cc/trees/occlusion_checker.h...
cc/trees/occlusion_checker.h:29: gfx::Transform draw_transform_;
On 2014/09/05 19:31:29, danakj wrote:
> This could really be part of the query, the rect + a transform from the rect
to
> the target. Saving the transform fixes the query space in place, which means
> you'd have to map queries for each tiling into the same space, instead of
giving
> a transform modified by the tiling scale. Idk which is nicer.

I kind of prefer to have the occlusion checker fixed to be in a particular
space, and have the caller modify the query rect to that space. Otherwise, I
feel like it might get a bit messy.

https://codereview.chromium.org/547723002/diff/1/cc/trees/occlusion_tracker.cc
File cc/trees/occlusion_tracker.cc (right):

https://codereview.chromium.org/547723002/diff/1/cc/trees/occlusion_tracker.c...
cc/trees/occlusion_tracker.cc:32: LayerType>::GenerateOcclusionChecker(const
LayerType* render_target,
On 2014/09/05 19:31:29, danakj wrote:
> not used, get rid of the render_target parameter. 

Done.

[vmpstr, 2014-09-09 00:17:30]

ping

[danakj, 2014-09-09 15:14:39]

LG overall, some naming nits/suggestions that you can disagree with. And The
template seems out of place to me.

https://codereview.chromium.org/547723002/diff/60001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/547723002/diff/60001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl.cc:481: const OcclusionTracker<LayerImpl>*
occlusion_tracker) {
even better is pass in the OcclusionChecker instead of an OT*

https://codereview.chromium.org/547723002/diff/60001/cc/resources/picture_lay...
File cc/resources/picture_layer_tiling.cc (right):

https://codereview.chromium.org/547723002/diff/60001/cc/resources/picture_lay...
cc/resources/picture_layer_tiling.cc:18: #include "cc/trees/occlusion_checker.h"
already in the .h

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
File cc/trees/occlusion_checker.cc (right):

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
cc/trees/occlusion_checker.cc:12:
OcclusionChecker<LayerType>::OcclusionChecker() {
wdyt of just naming this "Occlusion"? or maybe that loses something?

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
cc/trees/occlusion_checker.cc:26: bool OcclusionChecker<LayerType>::Occluded(
nit: IsOccluded

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
File cc/trees/occlusion_checker.h (right):

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
cc/trees/occlusion_checker.h:20: template <typename LayerType>
i don't see why this class is templated, can we remove that?

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
File cc/trees/occlusion_tracker.cc (right):

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
cc/trees/occlusion_tracker.cc:34: if (stack_.empty())
DCHECK this instead

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
cc/trees/occlusion_tracker.cc:40: return OcclusionChecker<LayerType>();
I'm not sure I see the point of this early out. What does it do for us?

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
File cc/trees/occlusion_tracker.h (right):

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
cc/trees/occlusion_tracker.h:41: OcclusionChecker<LayerType>
GenerateOcclusionChecker(
nit: GetCurrentOcclusionForLayer()? Or GetOcclusionForLayer()?

(I suggest the ForLayer suffix cuz this function doesn't handle contributing
surfaces.)

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
cc/trees/occlusion_tracker.h:55: bool Occluded(const LayerType* render_target,
Will followups work on removing these query methods from the OcclusionTracker
itself?

[vmpstr, 2014-09-09 21:56:57]

PTAL.

https://codereview.chromium.org/547723002/diff/60001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/547723002/diff/60001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl.cc:481: const OcclusionTracker<LayerImpl>*
occlusion_tracker) {
On 2014/09/09 15:14:39, danakj wrote:
> even better is pass in the OcclusionChecker instead of an OT*

Done. I'm passing occlusion to UpdateTiles. That way PLI doesn't nede to worry
about OcclusionTracker (aside from AppendQuads, which will also go away).

https://codereview.chromium.org/547723002/diff/60001/cc/resources/picture_lay...
File cc/resources/picture_layer_tiling.cc (right):

https://codereview.chromium.org/547723002/diff/60001/cc/resources/picture_lay...
cc/resources/picture_layer_tiling.cc:18: #include "cc/trees/occlusion_checker.h"
On 2014/09/09 15:14:39, danakj wrote:
> already in the .h

Done.

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
File cc/trees/occlusion_checker.cc (right):

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
cc/trees/occlusion_checker.cc:12:
OcclusionChecker<LayerType>::OcclusionChecker() {
On 2014/09/09 15:14:39, danakj wrote:
> wdyt of just naming this "Occlusion"? or maybe that loses something?

Done.

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
cc/trees/occlusion_checker.cc:26: bool OcclusionChecker<LayerType>::Occluded(
On 2014/09/09 15:14:39, danakj wrote:
> nit: IsOccluded

Done.

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
File cc/trees/occlusion_checker.h (right):

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_check...
cc/trees/occlusion_checker.h:20: template <typename LayerType>
On 2014/09/09 15:14:39, danakj wrote:
> i don't see why this class is templated, can we remove that?

Makes sense, I went overzealous with making it look like OcclusionTracker.

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
File cc/trees/occlusion_tracker.cc (right):

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
cc/trees/occlusion_tracker.cc:34: if (stack_.empty())
On 2014/09/09 15:14:39, danakj wrote:
> DCHECK this instead

Done.

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
cc/trees/occlusion_tracker.cc:40: return OcclusionChecker<LayerType>();
On 2014/09/09 15:14:39, danakj wrote:
> I'm not sure I see the point of this early out. What does it do for us?

Not much :) I removed it.

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
File cc/trees/occlusion_tracker.h (right):

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
cc/trees/occlusion_tracker.h:41: OcclusionChecker<LayerType>
GenerateOcclusionChecker(
On 2014/09/09 15:14:39, danakj wrote:
> nit: GetCurrentOcclusionForLayer()? Or GetOcclusionForLayer()?
> 
> (I suggest the ForLayer suffix cuz this function doesn't handle contributing
> surfaces.)

Changed to GetCurrentOcclusionForLayer

https://codereview.chromium.org/547723002/diff/60001/cc/trees/occlusion_track...
cc/trees/occlusion_tracker.h:55: bool Occluded(const LayerType* render_target,
On 2014/09/09 15:14:39, danakj wrote:
> Will followups work on removing these query methods from the OcclusionTracker
> itself?

Yes. I want to move to using Occlusion as early as possible in most (all?) cases
and just having the tracker where it makes sense. I do want to land this first,
so that the iterator thing can be reviewed in parallel.

[danakj, 2014-09-09 22:11:59]

LGTM w/ 2 things

https://codereview.chromium.org/547723002/diff/80001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/547723002/diff/80001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl_unittest.cc:3156:
active_layer_->UpdateTiles(Occlusion());
I <3 this so much.

https://codereview.chromium.org/547723002/diff/80001/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/547723002/diff/80001/cc/trees/layer_tree_impl...
cc/trees/layer_tree_impl.cc:508: const Occlusion& occlusion_in_layer_space =
I think you probably mean in_content_space which is the same thing as layer
space for picture layer now. Cuz it's based on the draw_transform() which comes
from content space.

https://codereview.chromium.org/547723002/diff/80001/cc/trees/occlusion.h
File cc/trees/occlusion.h (right):

https://codereview.chromium.org/547723002/diff/80001/cc/trees/occlusion.h#new...
cc/trees/occlusion.h:11: #include "ui/gfx/rect.h"
nit: can forward declare this

https://codereview.chromium.org/547723002/diff/80001/cc/trees/occlusion.h#new...
cc/trees/occlusion.h:30: Occlusion(const gfx::Transform& draw_transform,
Mildly prefer making this public and remove friends. Tests will want to make
these objects too, for example.

[vmpstr, 2014-09-10 00:32:24]

https://codereview.chromium.org/547723002/diff/80001/cc/layers/picture_layer_...
File cc/layers/picture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/547723002/diff/80001/cc/layers/picture_layer_...
cc/layers/picture_layer_impl_unittest.cc:3156:
active_layer_->UpdateTiles(Occlusion());
On 2014/09/09 22:11:59, danakj wrote:
> I <3 this so much.

:D

https://codereview.chromium.org/547723002/diff/80001/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/547723002/diff/80001/cc/trees/layer_tree_impl...
cc/trees/layer_tree_impl.cc:508: const Occlusion& occlusion_in_layer_space =
On 2014/09/09 22:11:59, danakj wrote:
> I think you probably mean in_content_space which is the same thing as layer
> space for picture layer now. Cuz it's based on the draw_transform() which
comes
> from content space.

Changed. So, it is technically layer space right? It's just called content
space? Note that I've changed this to in_content_space in PLI as well. However,
in PLT it's referred to as layer space, since its content space is different. Am
I understanding the names correctly?

https://codereview.chromium.org/547723002/diff/80001/cc/trees/occlusion.h
File cc/trees/occlusion.h (right):

https://codereview.chromium.org/547723002/diff/80001/cc/trees/occlusion.h#new...
cc/trees/occlusion.h:11: #include "ui/gfx/rect.h"
On 2014/09/09 22:11:59, danakj wrote:
> nit: can forward declare this

Done.

https://codereview.chromium.org/547723002/diff/80001/cc/trees/occlusion.h#new...
cc/trees/occlusion.h:30: Occlusion(const gfx::Transform& draw_transform,
On 2014/09/09 22:11:59, danakj wrote:
> Mildly prefer making this public and remove friends. Tests will want to make
> these objects too, for example.

Done.

[vmpstr, 2014-09-10 16:05:00]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-09-10 16:05:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/547723002/100001

[commit-bot: I haz the power, 2014-09-10 16:09:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 16:09:28]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/54078)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[danakj, 2014-09-10 16:49:10]

LGTM

[vmpstr, 2014-09-10 17:52:47]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-09-10 17:54:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmpstr@chromium.org/547723002/120001

[commit-bot: I haz the power, 2014-09-10 19:08:41]

Committed patchset #7 (id:120001) as d05d868f476ca46bd59cb3e98d517a1d4deccde0

[commit-bot: I haz the power, 2014-09-10 19:19:40]

Patchset 7 (id:??) landed as
https://crrev.com/1af780529157c94a9e0f05bcf478543b85714f6b
Cr-Commit-Position: refs/heads/master@{#294205}

[Michael Courage, 2014-09-10 19:31:08]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/551463005/ by courage@chromium.org.

The reason for reverting is: Broke linux GN build:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/11591

[496/2225 | 35.477] CXX obj/ui/views/controls/views.focusable_border.o
[497/2225 | 35.633] CXX obj/ui/views/controls/views.glow_hover_controller.o
FAILED: /mnt/data/b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/cc/layers/cc_unittests.picture_layer_impl_unittest.o.d -DCHROMIUM_BUILD
-DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_BACKGROUND=1
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_PEPPER_CDMS
-DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_FULL_PRINTING=1
-DENABLE_SPELLCHECK=1 -DUSE_UDEV -DTOOLKIT_VIEWS=1
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_CAIRO=1
-DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS=1
-DUSE_X11=1 -DUSE_XI2_MT=2 -DDISABLE_NACL -DENABLE_EXTENSIONS=1
-DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1
-DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1
-DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DCR_CLANG_REVISION=214024
-D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
-DGL_GLEXT_PROTOTYPES -DMEDIA_DISABLE_LIBVPX
-DSK_SUPPORT_LEGACY_PUBLIC_IMAGEINFO_FIELDS
-DSK_IGNORE_PROPER_FRACTIONAL_SCALING -DSK_SUPPORT_LEGACY_PICTURE_CLONE
-DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER
-DSK_SUPPORT_LEGACY_IMAGECACHE_NAME -DSK_LEGACY_PICTURE_SIZE_API
-DSK_LEGACY_PICTURE_DRAW_API -DSK_ENABLE_INST_COUNT=0
-DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\"
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_GPU=1 -DSK_USE_POSIX_THREADS
-DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0 -DUNIT_TEST
-I../.. -Igen -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos
-I../../gpu -Igen/ui/gl -I../../skia/config -I../../skia/ext
-I../../third_party/skia/include/config -I../../third_party/skia/include/core
-I../../third_party/skia/include/effects -I../../third_party/skia/include/images
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe
-I../../third_party/skia/include/ports -I../../third_party/skia/include/utils
-I../../third_party/skia/src/core -I../../third_party/skia/src/image
-I../../third_party/skia/src/opts -I../../third_party/skia/src/ports
-I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils
-I../../third_party/skia/src/lazy -I../../third_party/skia/include/gpu
-I../../third_party/skia/src/gpu -I../../testing/gtest/include
-I../../testing/gmock/include -fno-strict-aliasing -fstack-protector
--param=ssp-buffer-size=4 -m64 -funwind-tables -fPIC -pipe -pthread
-fcolor-diagnostics -Wall -Wextra -Wsign-compare -Wendif-labels -Werror
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register
-Wno-unused-function -fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion
-fno-ident -fdata-sections -ffunction-sections -O2 -g2 -fno-threadsafe-statics
-fvisibility-inlines-hidden -std=gnu++11 -Wno-reserved-user-defined-literal
-fno-rtti -fno-exceptions -c ../../cc/layers/picture_layer_impl_unittest.cc -o
obj/cc/layers/cc_unittests.picture_layer_impl_unittest.o
../../cc/layers/picture_layer_impl_unittest.cc:2578:31:error: reference to type
'const cc::Occlusion' could not bind to an rvalue of type 'long'
  pending_layer_->UpdateTiles(NULL);
                              ^~~~
/mnt/data/b/build/slave/Linux_GN/build/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.5.0/include/stddef.h:96:18:
note: expanded from macro 'NULL'
#    define NULL __null
                 ^~~~~~
../../cc/layers/picture_layer_impl.h:113:24: note: passing argument to parameter
'occlusion_in_content_space' here
      const Occlusion& occlusion_in_content_space) OVERRIDE;
                       ^
../../cc/layers/picture_layer_impl_unittest.cc:2608:31:error: reference to type
'const cc::Occlusion' could not bind to an rvalue of type 'long'
  pending_layer_->UpdateTiles(NULL);
                              ^~~~
/mnt/data/b/build/slave/Linux_GN/build/src/third_party/llvm-build/Release+Asserts/bin/../lib/clang/3.5.0/include/stddef.h:96:18:
note: expanded from macro 'NULL'
#    define NULL __null
                 ^~~~~~
../../cc/layers/picture_layer_impl.h:113:24: note: passing argument to parameter
'occlusion_in_content_space' here
      const Occlusion& occlusion_in_content_space) OVERRIDE;
                       ^
2 errors generated.
ninja: build stopped: subcommand failed.
.

[vmpstr, 2014-09-10 22:54:37]

PTAL for reland

[danakj, 2014-09-10 23:14:17]

lgtm

[danakj, 2014-09-10 23:14:23]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-09-10 23:18:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/547723002/140001

[commit-bot: I haz the power, 2014-09-11 00:59:24]

Committed patchset #8 (id:140001) as 02dab4320d1797869ad18d8c2c2b56686b750f5d

[commit-bot: I haz the power, 2014-09-11 01:02:40]

Patchset 8 (id:??) landed as
https://crrev.com/cdcb5f741f8163b771d66f6017a67cff06193b50
Cr-Commit-Position: refs/heads/master@{#294280}