Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/json_test.cc

Issue 547703002: Rework how types work in the VM Service. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html ('K') | « runtime/bin/vmservice/observatory/lib/src/service/object.dart ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/json_test.cc
diff --git a/runtime/vm/json_test.cc b/runtime/vm/json_test.cc
index b503cea416b3ed42fa588cbdb7b211154f6c26b5..43e0dbc7c7c248c64f4ab1112c31aa4a7f1b9c83 100644
--- a/runtime/vm/json_test.cc
+++ b/runtime/vm/json_test.cc
@@ -298,9 +298,9 @@ TEST_CASE(JSON_JSONStream_DartObject) {
JSONObject jsobj(&jsarr);
jsobj.AddProperty("object_key", Object::Handle(Object::null()));
}
- EXPECT_STREQ("[{\"type\":\"@Null\",\"id\":\"objects\\/null\","
+ EXPECT_STREQ("[{\"type\":\"@null\",\"id\":\"objects\\/null\","
"\"valueAsString\":\"null\"},"
- "{\"object_key\":{\"type\":\"@Null\",\"id\":\"objects\\/null\","
+ "{\"object_key\":{\"type\":\"@null\",\"id\":\"objects\\/null\","
"\"valueAsString\":\"null\"}}]",
js.ToCString());
}
« runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html ('K') | « runtime/bin/vmservice/observatory/lib/src/service/object.dart ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698