Rework how types work in the VM Service.

runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html

Index: runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html
diff --git a/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html b/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html
index 0c36ff752433b7ccf4c98f471b73a856f226d94a..72497e916224d2911c4bd95fad2120c76479f844 100644
--- a/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html
+++ b/runtime/bin/vmservice/observatory/lib/src/elements/instance_ref.html
@@ -22,11 +22,12 @@
         <div title="{{ hoverText }}">{{ ref.valueAsString }}</div>
       </template>
 
-      <template if="{{ ref.isString || ref.isBool || ref.isInt || ref.isDouble || ref.isNull }}">
+      <template if="{{ ref.isString || ref.isBool || ref.isInt ||
+                       ref.isDouble || ref.isNull }}">
         <a on-click="{{ goto }}" _href="{{ url }}">{{ ref.valueAsString }}</a>
       </template>
 
-      <template if="{{ ref.isType }}">
+      <template if="{{ ref.isAbstractType }}">
         <a on-click="{{ goto }}" _href="{{ url }}">{{ ref.name }}</a>
       </template>
 
@@ -37,7 +38,10 @@
         </a>
       </template>
 
-      <template if="{{ ref.isInstance && !ref.isClosure }}">
+      <template if="{{ ref.type == 'Instance' &&

[Cutch, 2014/09/09 16:41:15]

Can we pull this logic (ref.type == 'Instance') into Dart code again and use
that from the template? Feels brittle to have a type string comparison in a
template.

[turnidge, 2014/09/09 17:02:22]

Added an isPlainInstance getter.

+                       !ref.isClosure &&
+                       !ref.isMirrorReference &&
+                       !ref.isWeakProperty }}">
         <a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.clazz.name }}</em></a>
         <curly-block callback="{{ expander() }}">
           <div class="memberList">