Certificate Transparency: Code for unpacking EV cert hashes whitelist

chrome/browser/chrome_browser_main.cc

Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index fae377166606716bb4ed745830c25608ef227260..77ce209e26af92e93e62303c6e0be027f3230a6a 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -390,7 +390,7 @@ OSStatus KeychainCallback(SecKeychainEvent keychain_event,
 }
 #endif
 
-void RegisterComponentsForUpdate() {
+void RegisterComponentsForUpdate(net::SSLConfigService* ssl_config_service) {

[Sorin Jianu, 2014/10/01 18:50:02]

Eran, I see this additional parameter is dependent on the the profile. Will this
have some side effects as a result of the user changing profiles? 

[Eran Messeri, 2014/10/03 12:00:11]

Removed this, as I've reverted back to the approach of setting a global state on
the SSLConfigService, similar to CRLSets.
To answer your question, though, I *think* that it would not have side effects,
as there are some objects that are being copied from one profile to another
because they seem to be global configuration options (see
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...)

   component_updater::ComponentUpdateService* cus =
       g_browser_process->component_updater();
 
@@ -428,7 +428,7 @@ void RegisterComponentsForUpdate() {
 #if !defined(OS_ANDROID)
   // Android does not currently have the EV indicator. No need to get the
   // EV certs whitelist on Android, then.
-  RegisterEVWhitelistComponent(cus);
+  RegisterEVWhitelistComponent(cus, ssl_config_service);

[Ryan Sleevi, 2014/10/01 20:15:42]

CRLSets, which have a similar purpose as this, don't require passing in the
SSLCS. See 415-426

[Eran Messeri, 2014/10/03 12:00:11]

Done.

 #endif
 
 #if defined(OS_WIN)
@@ -1466,7 +1466,7 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
   browser_process_->notification_ui_manager();
 
   if (!parsed_command_line().HasSwitch(switches::kDisableComponentUpdate))
-    RegisterComponentsForUpdate();
+    RegisterComponentsForUpdate(profile_->GetSSLConfigService());

[Sorin Jianu, 2014/10/01 18:50:02]

I don't know how user switching and profiles work, I am just raising a concern
due to additional dependency injected here.

[Eran Messeri, 2014/10/03 12:00:11]

As mentioned, removed.

 
 #if defined(OS_ANDROID)
   chrome_variations::VariationsService* variations_service =