Certificate Transparency: Code for unpacking EV cert hashes whitelist

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 372 matching lines @@
   return NULL;
 }
 
 #if defined(OS_MACOSX)
 OSStatus KeychainCallback(SecKeychainEvent keychain_event,
                           SecKeychainCallbackInfo* info, void* context) {
   return noErr;
 }
 #endif
 
-void RegisterComponentsForUpdate() {
+void RegisterComponentsForUpdate(net::SSLConfigService* ssl_config_service) {

[Sorin Jianu, 2014/10/01 18:50:02]

Eran, I see this additional parameter is dependent on the the profile. Will this
have some side effects as a result of the user changing profiles? 

[Eran Messeri, 2014/10/03 12:00:11]

Removed this, as I've reverted back to the approach of setting a global state on
the SSLConfigService, similar to CRLSets.
To answer your question, though, I *think* that it would not have side effects,
as there are some objects that are being copied from one profile to another
because they seem to be global configuration options (see
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...)

   component_updater::ComponentUpdateService* cus =
       g_browser_process->component_updater();
 
   // Registration can be before or after cus->Start() so it is ok to post
   // a task to the UI thread to do registration once you done the necessary
   // file IO to know you existing component version.
 #if !defined(OS_CHROMEOS) && !defined(OS_ANDROID)
   RegisterRecoveryComponent(cus, g_browser_process->local_state());
   RegisterPepperFlashComponent(cus);
   RegisterSwiftShaderComponent(cus);
@@ skipping 17 matching lines @@
     // CRLSetFetcher attempts to load a CRL set from either the local disk or
     // network.
     // For Chrome OS this registration is delayed until user login.
     g_browser_process->crl_set_fetcher()->StartInitialLoad(cus, path);
 #endif
   }
 
 #if !defined(OS_ANDROID)
   // Android does not currently have the EV indicator. No need to get the
   // EV certs whitelist on Android, then.
-  RegisterEVWhitelistComponent(cus);
+  RegisterEVWhitelistComponent(cus, ssl_config_service);

[Ryan Sleevi, 2014/10/01 20:15:42]

CRLSets, which have a similar purpose as this, don't require passing in the
SSLCS. See 415-426

[Eran Messeri, 2014/10/03 12:00:11]

Done.

 #endif
 
 #if defined(OS_WIN)
   RegisterSwReporterComponent(cus, g_browser_process->local_state());
 #endif
 
   cus->Start();
 }
 
 #if !defined(OS_ANDROID)
@@ skipping 1017 matching lines @@
 
   PreBrowserStart();
 
   // Instantiate the notification UI manager, as this triggers a perf timer
   // used to measure startup time. TODO(stevenjb): Figure out what is actually
   // triggering the timer and call that explicitly in the approprate place.
   // http://crbug.com/105065.
   browser_process_->notification_ui_manager();
 
   if (!parsed_command_line().HasSwitch(switches::kDisableComponentUpdate))
-    RegisterComponentsForUpdate();
+    RegisterComponentsForUpdate(profile_->GetSSLConfigService());

[Sorin Jianu, 2014/10/01 18:50:02]

I don't know how user switching and profiles work, I am just raising a concern
due to additional dependency injected here.

[Eran Messeri, 2014/10/03 12:00:11]

As mentioned, removed.

 
 #if defined(OS_ANDROID)
   chrome_variations::VariationsService* variations_service =
       browser_process_->variations_service();
   if (variations_service) {
     variations_service->set_policy_pref_service(profile_->GetPrefs());
     variations_service->StartRepeatedVariationsSeedFetch();
   }
   translate::TranslateDownloadManager::RequestLanguageList(
       profile_->GetPrefs());
@@ skipping 196 matching lines @@
   chromeos::CrosSettings::Shutdown();
 #endif
 #endif
 }
 
 // Public members:
 
 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
   chrome_extra_parts_.push_back(parts);
 }