Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: chrome/browser/component_updater/ev_whitelist_component_installer.cc

Issue 547603002: Certificate Transparency: Code for unpacking EV cert hashes whitelist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding missing EV initialization to all tests in url_request Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cert/ct_ev_whitelist.h » ('j') | net/cert/ct_ev_whitelist.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/ev_whitelist_component_installer.cc
diff --git a/chrome/browser/component_updater/ev_whitelist_component_installer.cc b/chrome/browser/component_updater/ev_whitelist_component_installer.cc
index eeef0a602eb52924e636e4518b9135aac5f55e05..5f59306382b4f3e05b3f3205908d4f88e003b12f 100644
--- a/chrome/browser/component_updater/ev_whitelist_component_installer.cc
+++ b/chrome/browser/component_updater/ev_whitelist_component_installer.cc
@@ -65,16 +65,12 @@ void EVWhitelistComponentInstallerTraits::ComponentReady(
VLOG(1) << "Component ready, version " << version.GetString() << " in "
<< path.value();
- // TODO(eranm): Uncomment once https://codereview.chromium.org/462543002/
- // is in.
- /*
const base::FilePath whitelist_file = GetInstalledPath(path);
base::Callback<void(void)> set_cb =
base::Bind(&net::ct::SetEVWhitelistFromFile, whitelist_file);
content::BrowserThread::PostBlockingPoolTask(
FROM_HERE,
Sorin Jianu 2014/09/12 19:46:54 I think the arguments will fit on line 71. Or cons
Eran Messeri 2014/10/01 16:08:35 Done.
set_cb);
- */
}
bool EVWhitelistComponentInstallerTraits::VerifyInstallation(
« no previous file with comments | « no previous file | net/cert/ct_ev_whitelist.h » ('j') | net/cert/ct_ev_whitelist.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698