Certificate Transparency: Code for unpacking EV cert hashes whitelist

chrome/browser/component_updater/ev_whitelist_component_installer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/ev_whitelist_component_installer.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 47 matching lines @@
       .Append(kCompressedEVWhitelistFileName);
 }
 
 void EVWhitelistComponentInstallerTraits::ComponentReady(
     const base::Version& version,
     const base::FilePath& path,
     scoped_ptr<base::DictionaryValue> manifest) {
   VLOG(1) << "Component ready, version " << version.GetString() << " in "
           << path.value();
 
-  // TODO(eranm): Uncomment once https://codereview.chromium.org/462543002/
-  // is in.
-  /*
   const base::FilePath whitelist_file = GetInstalledPath(path);
   base::Callback<void(void)> set_cb =
       base::Bind(&net::ct::SetEVWhitelistFromFile, whitelist_file);
   content::BrowserThread::PostBlockingPoolTask(
       FROM_HERE,

[Sorin Jianu, 2014/09/12 19:46:54]

I think the arguments will fit on line 71. Or consider not using a named local
variable, since we have to vertically align parameters anyway.

[Eran Messeri, 2014/10/01 16:08:35]

Done.

       set_cb);
-      */
 }
 
 bool EVWhitelistComponentInstallerTraits::VerifyInstallation(
     const base::FilePath& install_dir) const {
   const base::FilePath expected_file = GetInstalledPath(install_dir);
   VLOG(1) << "Verifying install: " << expected_file.value();
   if (!base::PathExists(expected_file)) {
     VLOG(1) << "File missing.";
     return false;
   }
@@ skipping 30 matching lines @@
 
   scoped_ptr<ComponentInstallerTraits> traits(
       new EVWhitelistComponentInstallerTraits());
   // |cus| will take ownership of |installer| during installer->Register(cus).
   DefaultComponentInstaller* installer =
       new DefaultComponentInstaller(traits.Pass());
   installer->Register(cus);
 }
 
 }  // namespace component_updater