Add ShellAppsClient, ShellAppDelegate, ShellNativeAppWindow

extensions/shell/browser/shell_app_delegate.cc

Index: extensions/shell/browser/shell_app_delegate.cc
diff --git a/extensions/shell/browser/shell_app_delegate.cc b/extensions/shell/browser/shell_app_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..596a259054f01e8c1826a813441311077ebf7903
--- /dev/null
+++ b/extensions/shell/browser/shell_app_delegate.cc
@@ -0,0 +1,88 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "extensions/shell/browser/shell_app_delegate.h"
+
+#include "extensions/common/constants.h"
+
+namespace extensions {
+
+ShellAppDelegate::ShellAppDelegate() {
+}
+
+ShellAppDelegate::~ShellAppDelegate() {
+}
+
+void ShellAppDelegate::InitWebContents(content::WebContents* web_contents) {
+}
+
+void ShellAppDelegate::ResizeWebContents(content::WebContents* web_contents,
+                                         const gfx::Size& size) {
+  NOTIMPLEMENTED();

[James Cook, 2014/09/05 16:26:42]

Thanks for adding these NOTIMPLEMENTEDs. They make it much easier to debug
app_shell issues.

[hashimoto, 2014/09/05 17:37:16]

I left many methods unimplemented to start with the minimum set of
functionality.
Hope these NOTIMPLEMENTEDs get removed soon.

+}
+
+content::WebContents* ShellAppDelegate::OpenURLFromTab(
+    content::BrowserContext* context,
+    content::WebContents* source,
+    const content::OpenURLParams& params) {
+  NOTIMPLEMENTED();
+  return NULL;
+}
+
+void ShellAppDelegate::AddNewContents(content::BrowserContext* context,
+                                      content::WebContents* new_contents,
+                                      WindowOpenDisposition disposition,
+                                      const gfx::Rect& initial_pos,
+                                      bool user_gesture,
+                                      bool* was_blocked) {
+  NOTIMPLEMENTED();
+}
+
+content::ColorChooser* ShellAppDelegate::ShowColorChooser(
+    content::WebContents* web_contents,
+    SkColor initial_color) {
+  NOTIMPLEMENTED();
+  return NULL;
+}
+
+void ShellAppDelegate::RunFileChooser(
+    content::WebContents* tab,
+    const content::FileChooserParams& params) {
+  NOTIMPLEMENTED();
+}
+
+void ShellAppDelegate::RequestMediaAccessPermission(
+    content::WebContents* web_contents,
+    const content::MediaStreamRequest& request,
+    const content::MediaResponseCallback& callback,
+    const extensions::Extension* extension) {
+  NOTIMPLEMENTED();

[James Cook, 2014/09/05 16:26:42]

This should be hooked up to extensions/shell/browser/media_capture_util.h

[hashimoto, 2014/09/05 17:37:16]

Done.

+}
+
+int ShellAppDelegate::PreferredIconSize() {
+  return extension_misc::EXTENSION_ICON_SMALL;
+}
+
+gfx::ImageSkia ShellAppDelegate::GetAppDefaultIcon() {
+  NOTIMPLEMENTED();
+  return gfx::ImageSkia();
+}
+
+void ShellAppDelegate::SetWebContentsBlocked(
+    content::WebContents* web_contents,
+    bool blocked) {
+  NOTIMPLEMENTED();
+}
+
+bool ShellAppDelegate::IsWebContentsVisible(
+    content::WebContents* web_contents) {
+  NOTIMPLEMENTED();
+  return false;

[James Cook, 2014/09/05 16:26:42]

nit: maybe return true here? app_shell windows are always visible

[hashimoto, 2014/09/05 17:37:17]

Done.

+}
+
+void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) {
+  NOTIMPLEMENTED();
+}
+
+}  // namespace extensions