Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: extensions/shell/browser/shell_app_delegate.cc

Issue 547593002: Add ShellAppsClient, ShellAppDelegate, ShellNativeAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@apifeatures
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "extensions/shell/browser/shell_app_delegate.h"
6
7 #include "extensions/common/constants.h"
8
9 namespace extensions {
10
11 ShellAppDelegate::ShellAppDelegate() {
12 }
13
14 ShellAppDelegate::~ShellAppDelegate() {
15 }
16
17 void ShellAppDelegate::InitWebContents(content::WebContents* web_contents) {
18 }
19
20 void ShellAppDelegate::ResizeWebContents(content::WebContents* web_contents,
21 const gfx::Size& size) {
22 NOTIMPLEMENTED();
James Cook 2014/09/05 16:26:42 Thanks for adding these NOTIMPLEMENTEDs. They make
hashimoto 2014/09/05 17:37:16 I left many methods unimplemented to start with th
23 }
24
25 content::WebContents* ShellAppDelegate::OpenURLFromTab(
26 content::BrowserContext* context,
27 content::WebContents* source,
28 const content::OpenURLParams& params) {
29 NOTIMPLEMENTED();
30 return NULL;
31 }
32
33 void ShellAppDelegate::AddNewContents(content::BrowserContext* context,
34 content::WebContents* new_contents,
35 WindowOpenDisposition disposition,
36 const gfx::Rect& initial_pos,
37 bool user_gesture,
38 bool* was_blocked) {
39 NOTIMPLEMENTED();
40 }
41
42 content::ColorChooser* ShellAppDelegate::ShowColorChooser(
43 content::WebContents* web_contents,
44 SkColor initial_color) {
45 NOTIMPLEMENTED();
46 return NULL;
47 }
48
49 void ShellAppDelegate::RunFileChooser(
50 content::WebContents* tab,
51 const content::FileChooserParams& params) {
52 NOTIMPLEMENTED();
53 }
54
55 void ShellAppDelegate::RequestMediaAccessPermission(
56 content::WebContents* web_contents,
57 const content::MediaStreamRequest& request,
58 const content::MediaResponseCallback& callback,
59 const extensions::Extension* extension) {
60 NOTIMPLEMENTED();
James Cook 2014/09/05 16:26:42 This should be hooked up to extensions/shell/brows
hashimoto 2014/09/05 17:37:16 Done.
61 }
62
63 int ShellAppDelegate::PreferredIconSize() {
64 return extension_misc::EXTENSION_ICON_SMALL;
65 }
66
67 gfx::ImageSkia ShellAppDelegate::GetAppDefaultIcon() {
68 NOTIMPLEMENTED();
69 return gfx::ImageSkia();
70 }
71
72 void ShellAppDelegate::SetWebContentsBlocked(
73 content::WebContents* web_contents,
74 bool blocked) {
75 NOTIMPLEMENTED();
76 }
77
78 bool ShellAppDelegate::IsWebContentsVisible(
79 content::WebContents* web_contents) {
80 NOTIMPLEMENTED();
81 return false;
James Cook 2014/09/05 16:26:42 nit: maybe return true here? app_shell windows are
hashimoto 2014/09/05 17:37:17 Done.
82 }
83
84 void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) {
85 NOTIMPLEMENTED();
86 }
87
88 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698