Source/core/platform/graphics/Font.h - Issue 54743004: Rendering text-justify:distribute for 8 bit characters.

Unified Diff: Source/core/platform/graphics/Font.h

Issue 54743004: Rendering text-justify:distribute for 8 bit characters. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/linux/fast/css3-text/css3-text-justify/text-justify-8bits-expected.txt ('k') | Source/core/platform/graphics/Font.cpp » ('j') | Source/core/rendering/RenderBlockLineLayout.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/graphics/Font.h

diff --git a/Source/core/platform/graphics/Font.h b/Source/core/platform/graphics/Font.h

index f353f814cfadf49cbff4e09aa55f846950ef25e5..44553e9f5ddee64e921463d2535bbebee7215f74 100644

--- a/Source/core/platform/graphics/Font.h

+++ b/Source/core/platform/graphics/Font.h

@@ -156,8 +156,8 @@ public:

static bool isCJKIdeograph(UChar32);

static bool isCJKIdeographOrSymbol(UChar32);

- static unsigned expansionOpportunityCount(const LChar*, size_t length, TextDirection, bool& isAfterExpansion);

- static unsigned expansionOpportunityCount(const UChar*, size_t length, TextDirection, bool& isAfterExpansion);

+ static unsigned expansionOpportunityCount(const LChar*, size_t length, TextDirection, bool& isAfterExpansion, bool distributeJustification = false);

+ static unsigned expansionOpportunityCount(const UChar*, size_t length, TextDirection, bool& isAfterExpansion, bool distributeJustification = false);

leviw_travelin_and_unemployed 2013/11/04 19:37:58 Should we ever call this without passing in a valu

dw.im 2013/11/05 10:26:10 It seems ComplexTextController is only belong to m

leviw_travelin_and_unemployed 2013/11/05 19:07:24 Please add a complex text test case and we'll run

static void setShouldUseSmoothing(bool);

static bool shouldUseSmoothing();