Rendering text-justify:distribute for 8 bit characters.

Source/core/rendering/RenderBlockLineLayout.cpp

Index: Source/core/rendering/RenderBlockLineLayout.cpp
diff --git a/Source/core/rendering/RenderBlockLineLayout.cpp b/Source/core/rendering/RenderBlockLineLayout.cpp
index 422ed0570f28bc1d741e12f2dda20ba40e633ac1..1bf42a52170c526083b946336dc87c83a9c487dc 100644
--- a/Source/core/rendering/RenderBlockLineLayout.cpp
+++ b/Source/core/rendering/RenderBlockLineLayout.cpp
@@ -1057,9 +1057,9 @@ BidiRun* RenderBlockFlow::computeInlineDirectionPositionsForSegment(RootInlineBo
                     toInlineTextBox(r->m_box)->setCanHaveLeadingExpansion(true);
                 unsigned opportunitiesInRun;
                 if (rt->is8Bit())
-                    opportunitiesInRun = Font::expansionOpportunityCount(rt->characters8() + r->m_start, r->m_stop - r->m_start, r->m_box->direction(), isAfterExpansion);
+                    opportunitiesInRun = Font::expansionOpportunityCount(rt->characters8() + r->m_start, r->m_stop - r->m_start, r->m_box->direction(), isAfterExpansion, (textJustify == TextJustifyDistribute));

[leviw_travelin_and_unemployed, 2013/11/04 19:37:58]

I still think this is really ugly :-/ If the concept is known to Platform, I'd
rather the concept just be defined there, since this seems like a bandaid to
justify the layering violation.

[dw.im, 2013/11/05 10:26:10]

Hmm...
I'm not sure what could I do for this..

1st option is, declare the enum TextJustify at somewhere in core/platform, and
then include the file in core/rendering.
It looks weird...

2nd option is, declare one more enum at somewhere in core/platform, and, in
crde/rendering, convert TextJustify to the new enum value, and pass it as
parameter.
How about this?
such as.. enum TextJustifyValue { TextJustifyValueInterWord = 0x00,
TextJustifyValueDistribute = 0x01 } 
and, provide converting function, as well.

[leviw_travelin_and_unemployed, 2013/11/05 19:07:24]

I won't block this patch for this, I just think it's ugly. You also don't need
the extra parens.

                 else
-                    opportunitiesInRun = Font::expansionOpportunityCount(rt->characters16() + r->m_start, r->m_stop - r->m_start, r->m_box->direction(), isAfterExpansion);
+                    opportunitiesInRun = Font::expansionOpportunityCount(rt->characters16() + r->m_start, r->m_stop - r->m_start, r->m_box->direction(), isAfterExpansion, (textJustify == TextJustifyDistribute));
                 expansionOpportunities.append(opportunitiesInRun);
                 expansionOpportunityCount += opportunitiesInRun;
             }