Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: ui/views/window/dialog_client_view.cc

Issue 547253002: Ensure app install is aborted when the install dialog is closed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/window/dialog_client_view.cc
diff --git a/ui/views/window/dialog_client_view.cc b/ui/views/window/dialog_client_view.cc
index 17f71860057e63e8f736c39af8747044df309b31..e46586e442f4823efa3d32a187aa54b02916c0b6 100644
--- a/ui/views/window/dialog_client_view.cc
+++ b/ui/views/window/dialog_client_view.cc
@@ -139,6 +139,11 @@ bool DialogClientView::CanClose() {
return false;
}
+void DialogClientView::WidgetClosing() {
+ if (!notified_delegate_)
tapted 2014/09/08 07:42:21 do you need `notified_delegate_ = true` here, and
tmdiep 2014/09/08 08:26:08 DialogClientView::Close() is called by AcceptWindo
tapted 2014/09/08 09:28:56 sg - so long as Close() is private/non-virtual I t
+ GetDialogDelegate()->OnClosed();
+}
+
DialogClientView* DialogClientView::AsDialogClientView() {
return this;
}

Powered by Google App Engine
This is Rietveld 408576698