Ensure app install is aborted when the install dialog is closed

ui/views/window/dialog_client_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/window/dialog_client_view.h"
 
 #include <algorithm>
 
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "ui/views/background.h"
@@ skipping 121 matching lines @@
   // The dialog is closing but no Accept or Cancel action has been performed
   // before: it's a Close action.
   if (GetDialogDelegate()->Close()) {
     notified_delegate_ = true;
     GetDialogDelegate()->OnClosed();
     return true;
   }
   return false;
 }
 
+void DialogClientView::WidgetClosing() {
+  if (!notified_delegate_)

[tapted, 2014/09/08 07:42:21]

do you need `notified_delegate_ = true` here, and in DialogClientView::Close(),
below?

[tmdiep, 2014/09/08 08:26:08]

DialogClientView::Close() is called by AcceptWindow() and CancelWindow(), where
notified_delegate_ is set to true.

I went back and forth between whether to set the flag to true here.
The comment for notified_delegate_ in the header file says: "True if we've
notified the delegate the window is closing and the delegate allowed the close."
In this case the delegate did not allow the close, but the window is closing, so
I opted for this to ensure this flow remains unchanged:
When there is an accept, the order of execution is line 71 -> 429 -> 129
(returns at 130) -> 143 -> 430. 

[tapted, 2014/09/08 09:28:56]

sg - so long as Close() is private/non-virtual I think it makes sense

+    GetDialogDelegate()->OnClosed();
+}
+
 DialogClientView* DialogClientView::AsDialogClientView() {
   return this;
 }
 
 const DialogClientView* DialogClientView::AsDialogClientView() const {
   return this;
 }
 
 void DialogClientView::OnWillChangeFocus(View* focused_before,
                                          View* focused_now) {
@@ skipping 267 matching lines @@
       gfx::Insets(0, kButtonHEdgeMarginNew,
                   kButtonVEdgeMarginNew, kButtonHEdgeMarginNew);
 }
 
 void DialogClientView::Close() {
   GetWidget()->Close();
   GetDialogDelegate()->OnClosed();
 }
 
 }  // namespace views