Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc

Issue 547053002: [NaCl SDK] nacl_io: Remove Node::Access method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@http_fs_root
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc b/native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc
index 3c215eae1faf8d2630b856a7ad4d91b9557f5456..b654c999c53a0bfbb5a800ebf53cf4dcbfd9055a 100644
--- a/native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc
+++ b/native_client_sdk/src/tests/nacl_io_test/http_fs_test.cc
@@ -78,15 +78,6 @@ class HttpFsLargeFileTest : public HttpFsTest {
} // namespace
-TEST_P(HttpFsTest, Access) {
- ASSERT_TRUE(ppapi_.server_template()->AddEntity("foo", "", NULL));
-
- ASSERT_EQ(0, fs_.Access(Path("/foo"), R_OK));
- ASSERT_EQ(EACCES, fs_.Access(Path("/foo"), W_OK));
- ASSERT_EQ(EACCES, fs_.Access(Path("/foo"), X_OK));
- ASSERT_EQ(ENOENT, fs_.Access(Path("/bar"), F_OK));
-}
-
TEST_P(HttpFsTest, OpenAndCloseServerError) {
EXPECT_TRUE(ppapi_.server_template()->AddError("file", 500));
@@ -278,9 +269,9 @@ TEST(HttpFsDirTest, Root) {
ASSERT_TRUE(node->IsaDir());
// We have to r+w access to the root node
- ASSERT_EQ(0, fs.Access(Path("/"), R_OK));
- ASSERT_EQ(0, fs.Access(Path("/"), X_OK));
- ASSERT_EQ(EACCES, fs.Access(Path("/"), W_OK));
+ struct stat buf;
+ ASSERT_EQ(0, node->GetStat(&buf));
+ ASSERT_EQ(S_IXUSR | S_IRUSR, buf.st_mode & S_IRWXU);
}
TEST(HttpFsDirTest, Mkdir) {
@@ -392,11 +383,6 @@ TEST(HttpFsBlobUrlTest, Basic) {
HttpFsForTesting fs(args, &ppapi);
- // Check access to root folder
- ASSERT_EQ(0, fs.Access(Path("/"), R_OK));
- ASSERT_EQ(0, fs.Access(Path("/"), X_OK));
- ASSERT_EQ(EACCES, fs.Access(Path("/"), W_OK));
-
// Verify the root is a directory containing a single file
ScopedNode node;
ASSERT_EQ(0, fs.Open(Path("/"), O_RDONLY, &node));
@@ -415,5 +401,4 @@ TEST(HttpFsBlobUrlTest, Basic) {
ASSERT_EQ(0, node->GetStat(&statbuf));
ASSERT_EQ(0, node->GetStat(&statbuf));
ASSERT_EQ(strlen(kContent), statbuf.st_size);
-
}

Powered by Google App Engine
This is Rietveld 408576698