native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h - Issue 547053002: [NaCl SDK] nacl_io: Remove Node::Access method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h

Issue 547053002: [NaCl SDK] nacl_io: Remove Node::Access method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@http_fs_root

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc ('K') | « native_client_sdk/src/libraries/nacl_io/stream/stream_fs.cc ('k') | native_client_sdk/src/tests/nacl_io_test/filesystem_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h

diff --git a/native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h b/native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h

index a898a126416f0bc9ca59d2b9c565ae4018fc7ad3..6330e42a3b975b5731defd44e7a9dbd73ac643c2 100644

--- a/native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h

+++ b/native_client_sdk/src/tests/nacl_io_test/dev_fs_for_testing.h

@@ -14,6 +14,11 @@

class DevFsForTesting : public nacl_io::DevFs {

public:

+ bool Exists(const char* filename) {

binji 2014/09/08 18:48:26 nit: move below constructor

Sam Clegg 2014/09/09 19:58:30 Done.

+ struct stat buf;

+ return stat(filename, &buf) == 0;

binji 2014/09/08 18:48:26 better to call ki_stat, I think. Or do what the ot

Sam Clegg 2014/09/09 19:58:30 Done.

+ }

explicit DevFsForTesting(nacl_io::PepperInterface* ppapi) {

nacl_io::FsInitArgs args(1);

args.ppapi = ppapi;