Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 546973003: [android] Proguard out most of guava (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
Reviewers:
Yaron, brettw
CC:
chromium-reviews, tim+watch_chromium.org, plundblad+watch_chromium.org, zea+watch_chromium.org, aboxhall+watch_chromium.org, haitaol+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, maniscalco+watch_chromium.org, Tyler Breisacher (Chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[android] Proguard out most of guava This CL removes most of guava, except a few classes and annotations. Also updates the rest of Chrome to ensure only those classes are in use. Thirdly, it adds an OWNERS file to third_party/guava. BUG=163393 TBR=brettw@chromium.org Committed: https://crrev.com/b09a5e56c9bf2eabedf39a52c54fbb85bbd41e3a Cr-Commit-Position: refs/heads/master@{#293828}

Patch Set 1 #

Patch Set 2 : Remove clouser_compiler runner.jar #

Patch Set 3 : Merged in from master (clean merge) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java View 2 chunks +1 line, -2 lines 0 comments Download
A + third_party/guava/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/guava/proguard.flags View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
nyquist
yfriedman: PTAL PS: Adding you as OWNERS
6 years, 3 months ago (2014-09-06 01:01:45 UTC) #2
Yaron
lgtm Once cacheinvalidation no longer uses it, I think we should just nuke it from ...
6 years, 3 months ago (2014-09-06 01:12:31 UTC) #3
nyquist
brettw: TBRing for adding OWNERS for guava. I forgot to add the OWNERS when I ...
6 years, 3 months ago (2014-09-08 18:25:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/546973003/40001
6 years, 3 months ago (2014-09-08 20:20:15 UTC) #7
brettw
lgtm
6 years, 3 months ago (2014-09-08 20:43:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/546973003/40001
6 years, 3 months ago (2014-09-08 23:43:53 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 84c8aae1606c6b9b19f178252440d164d77dd5b1
6 years, 3 months ago (2014-09-09 01:18:35 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:49:31 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b09a5e56c9bf2eabedf39a52c54fbb85bbd41e3a
Cr-Commit-Position: refs/heads/master@{#293828}

Powered by Google App Engine
This is Rietveld 408576698