Issue 11415141: Add guava and jsr-305 to third_party for Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415141: Add guava and jsr-305 to third_party for Android (Closed)

Created:
8 years ago by nyquist

Modified:
8 years ago

Reviewers:
szager1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add guava and jsr-305 to third_party for Android Instead of using bundled versions of guava, we now instead build guava ourselves. Also, we need to build jsr-305 as it is the only dependency guava has. BUG=159873 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170751

Patch Set 1 #

Patch Set 2 : Remove DEPS and .gitignore change #

Patch Set 3 : Rebased #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -13 lines)			Patch
M	third_party/cacheinvalidation/cacheinvalidation.gyp	View		2 chunks	+1 line, -13 lines	0 comments	Download
A	third_party/guava/README.chromium	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A	third_party/guava/guava.gyp	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
A	third_party/jsr-305/README.chromium	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	third_party/jsr-305/jsr-305.gyp	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages